[U-Boot] [PATCH 5/6] arm: socfpga: Introduce common board code

Marek Vasut
2015-12-07T13:23:26Z

On Monday, December 07, 2015 at 01:53:48 PM, Chin Liang See wrote:

[...]

> > diff --git a/arch/arm/mach-socfpga/board.c b/arch/arm/mach
> > -socfpga/board.c
> > new file mode 100644
> > index 0000000..a41d089
> > --- /dev/null
> > +++ b/arch/arm/mach-socfpga/board.c
>
> I am thinking this can go into misc.c instead new file.

misc.c is bloated with random crap already, I would like to keep things
orderly a little. Let's keep the board code and platform code separated.

> > @@ -0,0 +1,64 @@
> > +/*
> > + * Altera SoCFPGA common board code
> > + *
> > + * Copyright (C) 2015 Marek Vasut <marex@denx.de>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0+
> > + */
> > +
> > +#include <common.h>
> > +#include <errno.h>
> > +#include <asm/arch/reset_manager.h>
> > +#include <asm/io.h>
> > +
> > +#include <usb.h>
> > +#include <usb/dwc2_udc.h>
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
> > +
> > +void s_init(void) {}
> > +
> > +/*
> > + * Miscellaneous platform dependent initialisations
> > + */
> > +int board_init(void)
>
> I am thinking we can skip the board_init where it located at original
> board folder. If user has unique board specific initialization, they
> can still do it there.

See my reply to 6/6 .

Best regards,
Marek Vasut