* [U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds
@ 2015-10-30 15:21 Michal Simek
2015-11-03 10:14 ` Lukasz Majewski
0 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2015-10-30 15:21 UTC (permalink / raw)
To: u-boot
Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid
pointer from integer cast size mismatch warnings.
Warning log:
+../drivers/usb/gadget/udc/udc-core.c: In function
?usb_gadget_unmap_request?:
+../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer
from integer of different size [-Wint-to-pointer-cast]
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/usb/gadget/udc/udc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c
index 875e998a82e3..326757b547fa 100644
--- a/drivers/usb/gadget/udc/udc-core.c
+++ b/drivers/usb/gadget/udc/udc-core.c
@@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget *gadget,
if (req->length == 0)
return;
- dma_unmap_single((void *)req->dma, req->length,
+ dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
}
EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
--
2.5.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds
2015-10-30 15:21 [U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds Michal Simek
@ 2015-11-03 10:14 ` Lukasz Majewski
2015-12-07 12:01 ` Michal Simek
0 siblings, 1 reply; 7+ messages in thread
From: Lukasz Majewski @ 2015-11-03 10:14 UTC (permalink / raw)
To: u-boot
Hi Michal,
> Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid
> pointer from integer cast size mismatch warnings.
>
> Warning log:
> +../drivers/usb/gadget/udc/udc-core.c: In function
> ?usb_gadget_unmap_request?:
> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer
> from integer of different size [-Wint-to-pointer-cast]
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/usb/gadget/udc/udc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/udc-core.c
> b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa
> 100644 --- a/drivers/usb/gadget/udc/udc-core.c
> +++ b/drivers/usb/gadget/udc/udc-core.c
> @@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget
> *gadget, if (req->length == 0)
> return;
>
> - dma_unmap_single((void *)req->dma, req->length,
> + dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
> is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
> }
> EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds
2015-11-03 10:14 ` Lukasz Majewski
@ 2015-12-07 12:01 ` Michal Simek
2015-12-08 6:59 ` Lukasz Majewski
2015-12-09 9:33 ` Lukasz Majewski
0 siblings, 2 replies; 7+ messages in thread
From: Michal Simek @ 2015-12-07 12:01 UTC (permalink / raw)
To: u-boot
Hi Marek and Lukasz,
On 3.11.2015 11:14, Lukasz Majewski wrote:
> Hi Michal,
>
>> Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid
>> pointer from integer cast size mismatch warnings.
>>
>> Warning log:
>> +../drivers/usb/gadget/udc/udc-core.c: In function
>> ?usb_gadget_unmap_request?:
>> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer
>> from integer of different size [-Wint-to-pointer-cast]
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> drivers/usb/gadget/udc/udc-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/udc/udc-core.c
>> b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa
>> 100644 --- a/drivers/usb/gadget/udc/udc-core.c
>> +++ b/drivers/usb/gadget/udc/udc-core.c
>> @@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget
>> *gadget, if (req->length == 0)
>> return;
>>
>> - dma_unmap_single((void *)req->dma, req->length,
>> + dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
>> is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
>> }
>> EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>
Is this patch in any of your queue?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151207/e0e1431b/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds
2015-12-07 12:01 ` Michal Simek
@ 2015-12-08 6:59 ` Lukasz Majewski
2015-12-08 7:18 ` Michal Simek
2015-12-09 9:33 ` Lukasz Majewski
1 sibling, 1 reply; 7+ messages in thread
From: Lukasz Majewski @ 2015-12-08 6:59 UTC (permalink / raw)
To: u-boot
Hi Michal,
> Hi Marek and Lukasz,
>
> On 3.11.2015 11:14, Lukasz Majewski wrote:
> > Hi Michal,
> >
> >> Cast u32 bit value to 64bit before recasting to 64bit pointer to
> >> avoid pointer from integer cast size mismatch warnings.
> >>
> >> Warning log:
> >> +../drivers/usb/gadget/udc/udc-core.c: In function
> >> ?usb_gadget_unmap_request?:
> >> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to
> >> pointer from integer of different size [-Wint-to-pointer-cast]
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >> drivers/usb/gadget/udc/udc-core.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/usb/gadget/udc/udc-core.c
> >> b/drivers/usb/gadget/udc/udc-core.c index
> >> 875e998a82e3..326757b547fa 100644 ---
> >> a/drivers/usb/gadget/udc/udc-core.c +++
> >> b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void
> >> usb_gadget_unmap_request(struct usb_gadget *gadget, if
> >> (req->length == 0) return;
> >>
> >> - dma_unmap_single((void *)req->dma, req->length,
> >> + dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
> >> is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
> >> }
> >> EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
> >
> > Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> >
>
> Is this patch in any of your queue?
>
> Thanks,
> Michal
>
I can grab this to -dfu tree since I'm in the middle of preparing PR.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds
2015-12-08 6:59 ` Lukasz Majewski
@ 2015-12-08 7:18 ` Michal Simek
0 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2015-12-08 7:18 UTC (permalink / raw)
To: u-boot
On 8.12.2015 07:59, Lukasz Majewski wrote:
> Hi Michal,
>
>> Hi Marek and Lukasz,
>>
>> On 3.11.2015 11:14, Lukasz Majewski wrote:
>>> Hi Michal,
>>>
>>>> Cast u32 bit value to 64bit before recasting to 64bit pointer to
>>>> avoid pointer from integer cast size mismatch warnings.
>>>>
>>>> Warning log:
>>>> +../drivers/usb/gadget/udc/udc-core.c: In function
>>>> ?usb_gadget_unmap_request?:
>>>> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to
>>>> pointer from integer of different size [-Wint-to-pointer-cast]
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> ---
>>>>
>>>> drivers/usb/gadget/udc/udc-core.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/usb/gadget/udc/udc-core.c
>>>> b/drivers/usb/gadget/udc/udc-core.c index
>>>> 875e998a82e3..326757b547fa 100644 ---
>>>> a/drivers/usb/gadget/udc/udc-core.c +++
>>>> b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void
>>>> usb_gadget_unmap_request(struct usb_gadget *gadget, if
>>>> (req->length == 0) return;
>>>>
>>>> - dma_unmap_single((void *)req->dma, req->length,
>>>> + dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
>>>> is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
>>>> }
>>>> EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
>>>
>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>
>>
>> Is this patch in any of your queue?
>>
>> Thanks,
>> Michal
>>
>
> I can grab this to -dfu tree since I'm in the middle of preparing PR.
>
Thanks,
Michal
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds
2015-12-07 12:01 ` Michal Simek
2015-12-08 6:59 ` Lukasz Majewski
@ 2015-12-09 9:33 ` Lukasz Majewski
2015-12-09 9:40 ` Michal Simek
1 sibling, 1 reply; 7+ messages in thread
From: Lukasz Majewski @ 2015-12-09 9:33 UTC (permalink / raw)
To: u-boot
Hi Michal,
> Hi Marek and Lukasz,
>
> On 3.11.2015 11:14, Lukasz Majewski wrote:
> > Hi Michal,
> >
> >> Cast u32 bit value to 64bit before recasting to 64bit pointer to
> >> avoid pointer from integer cast size mismatch warnings.
> >>
> >> Warning log:
> >> +../drivers/usb/gadget/udc/udc-core.c: In function
> >> ?usb_gadget_unmap_request?:
> >> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to
> >> pointer from integer of different size [-Wint-to-pointer-cast]
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >> drivers/usb/gadget/udc/udc-core.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/usb/gadget/udc/udc-core.c
> >> b/drivers/usb/gadget/udc/udc-core.c index
> >> 875e998a82e3..326757b547fa 100644 ---
> >> a/drivers/usb/gadget/udc/udc-core.c +++
> >> b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void
> >> usb_gadget_unmap_request(struct usb_gadget *gadget, if
> >> (req->length == 0) return;
> >>
> >> - dma_unmap_single((void *)req->dma, req->length,
> >> + dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
> >> is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
> >> }
> >> EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
> >
> > Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> >
>
> Is this patch in any of your queue?
It is already applied to -usb tree :-).
>
> Thanks,
> Michal
>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds
2015-12-09 9:33 ` Lukasz Majewski
@ 2015-12-09 9:40 ` Michal Simek
0 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2015-12-09 9:40 UTC (permalink / raw)
To: u-boot
On 9.12.2015 10:33, Lukasz Majewski wrote:
> Hi Michal,
>
>> Hi Marek and Lukasz,
>>
>> On 3.11.2015 11:14, Lukasz Majewski wrote:
>>> Hi Michal,
>>>
>>>> Cast u32 bit value to 64bit before recasting to 64bit pointer to
>>>> avoid pointer from integer cast size mismatch warnings.
>>>>
>>>> Warning log:
>>>> +../drivers/usb/gadget/udc/udc-core.c: In function
>>>> ?usb_gadget_unmap_request?:
>>>> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to
>>>> pointer from integer of different size [-Wint-to-pointer-cast]
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> ---
>>>>
>>>> drivers/usb/gadget/udc/udc-core.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/usb/gadget/udc/udc-core.c
>>>> b/drivers/usb/gadget/udc/udc-core.c index
>>>> 875e998a82e3..326757b547fa 100644 ---
>>>> a/drivers/usb/gadget/udc/udc-core.c +++
>>>> b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void
>>>> usb_gadget_unmap_request(struct usb_gadget *gadget, if
>>>> (req->length == 0) return;
>>>>
>>>> - dma_unmap_single((void *)req->dma, req->length,
>>>> + dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
>>>> is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
>>>> }
>>>> EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
>>>
>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>
>>
>> Is this patch in any of your queue?
>
> It is already applied to -usb tree :-).
Then great.
Thanks,
Michal
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-12-09 9:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-30 15:21 [U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds Michal Simek
2015-11-03 10:14 ` Lukasz Majewski
2015-12-07 12:01 ` Michal Simek
2015-12-08 6:59 ` Lukasz Majewski
2015-12-08 7:18 ` Michal Simek
2015-12-09 9:33 ` Lukasz Majewski
2015-12-09 9:40 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox