From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 11 Dec 2015 16:24:46 +0100
Subject: [U-Boot] [PATCH V2 1/1] Revert "spi: fsl_qspi: Use GENMASK"
In-Reply-To: <CAD6G_RS7edm-eMRGVx6+P9-JSn-eBv1Omn2DZywWEth7bYiOGA@mail.gmail.com>
References: <1449782863-15230-1-git-send-email-troy.kisky@boundarydevices.com>
 <CAD6G_RS7edm-eMRGVx6+P9-JSn-eBv1Omn2DZywWEth7bYiOGA@mail.gmail.com>
Message-ID: <201512111624.46826.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday, December 11, 2015 at 03:59:14 PM, Jagan Teki wrote:
> On 11 December 2015 at 02:57, Troy Kisky <troy.kisky@boundarydevices.com> 
wrote:
> > If GENMASK is REALLY desired, it should be GENMASK(23,0)
> > But since GENMASK is obviously more confusing, let's just revert.
> > 
> > This reverts commit bad490a24212c068c5b718b9189f47ea4075d078.
> 
> Sorry, just fix genmask why revert? because driver author has no
> complaint on this, please don't just say simply "more confusing" more
> over I usually prefer reverting bug fix patches.

I also agree this GENMASK() crap is confusing.

> > Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>
> > Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> > 
> > ---
> > v2: add sign off/ reviewed by
> > ---
> > 
> >  drivers/spi/fsl_qspi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c
> > index ed39114..dd7048a 100644
> > --- a/drivers/spi/fsl_qspi.c
> > +++ b/drivers/spi/fsl_qspi.c
> > @@ -24,7 +24,7 @@ DECLARE_GLOBAL_DATA_PTR;
> > 
> >  #define TX_BUFFER_SIZE         0x40
> >  #endif
> > 
> > -#define OFFSET_BITS_MASK       GENMASK(24, 0)
> > +#define OFFSET_BITS_MASK       0x00ffffff
> > 
> >  #define FLASH_STATUS_WEL       0x02
> > 
> > --
> > 2.5.0
> 
> thanks!

Best regards,
Marek Vasut