[U-Boot] [PATCH 1/6] arm: socfpga: cyclone5-socdk: Enabling mtd partitioning layout

Marek Vasut
2015-12-12T03:20:48Z

On Saturday, December 12, 2015 at 12:59:02 AM, Chin Liang See wrote:
> On Fri, 2015-12-11 at 15:21 +0100, Marek Vasut wrote:
> > On Friday, December 11, 2015 at 10:15:48 AM, Chin Liang See wrote:
> > > Enabling mtd partitioning layout which indicate partition
> > > for various boot partition
> > >
> > > Signed-off-by: Chin Liang See <clsee@altera.com>
> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > > Cc: Pavel Machek <pavel@denx.de>
> > > Cc: Marek Vasut <marex@denx.de>
> > > Cc: Stefan Roese <sr@denx.de>
> > > ---
> > >
> > > include/configs/socfpga_cyclone5_socdk.h | 12 ++++++++++++
> > > 1 file changed, 12 insertions(+)
> > >
> > > diff --git a/include/configs/socfpga_cyclone5_socdk.h
> > > b/include/configs/socfpga_cyclone5_socdk.h index 67bb35f..e4a1657
> > > 100644
> > > --- a/include/configs/socfpga_cyclone5_socdk.h
> > > +++ b/include/configs/socfpga_cyclone5_socdk.h
> > > @@ -96,4 +96,16 @@
> > >
> > > /* The rest of the configuration is shared */
> > > #include <configs/socfpga_common.h>
> > >
> > > +/* mtd partitioning for serial NOR flash */
> > > +#if defined(CONFIG_CMD_UBI) || defined(CONFIG_CMD_SF)
> >
> > Is this the default Altera layout ?
>
> Yah but believe it need to be updated

So you're not worried about compatibility I presume ?

> > > +#define MTDPARTS_DEFAULT "mtdparts=ff705000.spi:"\
> > > + "256k(spl)," \
> > > + "64k(env)," \
> > > + "64k(dtb)," \
> >
> > What happens if the DT grows over 64k ?
>
> Hmmm rethinking of this, I will make Linux dtb, U-Boot and kernel as
> part of one big UBI partition called boot.

I am using this sort of layout on SoCkit internally:

"mtdparts=ff705000.spi:" \
"1m(u-boot)," \
"64k(env1)," \
"64k(env2)," \
"-(UBI)\0"

I have two environment blocks to implement redundant env, which is useful
when deploying the system. It makes the system slightly more resilient
against problems of aging flash.

> > > + "256k(boot)," \
> >
> > 256k is not enough for U-Boot (considering this is U-Boot).
>
> Will create boot region to avoid worrying the size issue
>
> > > + "16m(kernel)," \
> > > + "16m(rootfs)," \
> >
> > Why don't you put kernel and rootfs onto the UBI volume instead ?
>
> Yup, kernel will go into boot partition. It will be separated from
> rootfs as user might choose nfs.

Can you share the final layout before you roll out patches ?