From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] eeprom: fix eeprom write procedure
Date: Tue, 15 Dec 2015 01:27:08 +0100 [thread overview]
Message-ID: <201512150127.09020.marex@denx.de> (raw)
In-Reply-To: <1450107934-7362-1-git-send-email-abrodkin@synopsys.com>
On Monday, December 14, 2015 at 04:45:34 PM, Alexey Brodkin wrote:
> This fixes commit 1a37889b0ad084a740b4f785031d7ae9955d947b:
> ----------------------->8--------------------
> eeprom: Pull out the RW loop
>
> Unify the code for doing read/write into single function, since the
> code for both the read and write is almost identical. This again
> trims down the code duplication.
> ----------------------->8--------------------
>
> where the same one routine is utilized for both EEPROM writing and
> reading. The only difference was supposed to be a "read" flag which
> in both cases was set with 1 somehow.
>
> That lead to a missing delay in case of writing which lead to write
> failure (in my case no data was written).
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Heiko Schocher <hs@denx.de>
Obviously correct,
Acked-by: Marek Vasut <marex@denx.de>
Thanks for spotting this, nice!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-12-15 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 15:45 [U-Boot] [PATCH] eeprom: fix eeprom write procedure Alexey Brodkin
2015-12-15 0:27 ` Marek Vasut [this message]
2015-12-15 8:07 ` Alexey Brodkin
2015-12-15 11:47 ` Marek Vasut
2015-12-15 12:09 ` Alexey Brodkin
2015-12-15 23:36 ` Tom Rini
2015-12-16 15:31 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201512150127.09020.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox