* [U-Boot] [PATCH] nios2: display altera sysid at startup
@ 2015-12-16 8:07 Thomas Chou
2015-12-16 10:25 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Chou @ 2015-12-16 8:07 UTC (permalink / raw)
To: u-boot
Display altera sysid at startup, which was once removed during
the move.
Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
arch/nios2/cpu/cpu.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/nios2/cpu/cpu.c b/arch/nios2/cpu/cpu.c
index f6d5cd3..be7f99c 100644
--- a/arch/nios2/cpu/cpu.c
+++ b/arch/nios2/cpu/cpu.c
@@ -21,6 +21,14 @@ int print_cpuinfo(void)
}
#endif /* CONFIG_DISPLAY_CPUINFO */
+#ifdef CONFIG_ALTERA_SYSID
+int checkboard(void)
+{
+ display_sysid();
+ return 0;
+}
+#endif
+
int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
disable_interrupts();
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] nios2: display altera sysid at startup
2015-12-16 8:07 [U-Boot] [PATCH] nios2: display altera sysid at startup Thomas Chou
@ 2015-12-16 10:25 ` Marek Vasut
2015-12-16 13:10 ` Thomas Chou
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2015-12-16 10:25 UTC (permalink / raw)
To: u-boot
On Wednesday, December 16, 2015 at 09:07:47 AM, Thomas Chou wrote:
> Display altera sysid at startup, which was once removed during
> the move.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
What if the sysid block isn't part of the design ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] nios2: display altera sysid at startup
2015-12-16 10:25 ` Marek Vasut
@ 2015-12-16 13:10 ` Thomas Chou
2015-12-16 13:23 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Chou @ 2015-12-16 13:10 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 2015?12?16? 18:25, Marek Vasut wrote:
> On Wednesday, December 16, 2015 at 09:07:47 AM, Thomas Chou wrote:
>> Display altera sysid at startup, which was once removed during
>> the move.
>>
>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>
> What if the sysid block isn't part of the design ?
If the sysid block is not present, nothing will display and it is not an
error.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] nios2: display altera sysid at startup
2015-12-16 13:10 ` Thomas Chou
@ 2015-12-16 13:23 ` Marek Vasut
2015-12-16 13:44 ` Thomas Chou
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2015-12-16 13:23 UTC (permalink / raw)
To: u-boot
On Wednesday, December 16, 2015 at 02:10:26 PM, Thomas Chou wrote:
> Hi Marek,
Hi!
> On 2015?12?16? 18:25, Marek Vasut wrote:
> > On Wednesday, December 16, 2015 at 09:07:47 AM, Thomas Chou wrote:
> >> Display altera sysid at startup, which was once removed during
> >> the move.
> >>
> >> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> >
> > What if the sysid block isn't part of the design ?
>
> If the sysid block is not present, nothing will display and it is not an
> error.
Won't this cause bus stall if you try to access unpopulated location ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] nios2: display altera sysid at startup
2015-12-16 13:23 ` Marek Vasut
@ 2015-12-16 13:44 ` Thomas Chou
2015-12-16 14:01 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Chou @ 2015-12-16 13:44 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 2015?12?16? 21:23, Marek Vasut wrote:
> On Wednesday, December 16, 2015 at 02:10:26 PM, Thomas Chou wrote:
>> Hi Marek,
>
> Hi!
>
>> On 2015?12?16? 18:25, Marek Vasut wrote:
>>> On Wednesday, December 16, 2015 at 09:07:47 AM, Thomas Chou wrote:
>>>> Display altera sysid at startup, which was once removed during
>>>> the move.
>>>>
>>>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>>>
>>> What if the sysid block isn't part of the design ?
>>
>> If the sysid block is not present, nothing will display and it is not an
>> error.
>
> Won't this cause bus stall if you try to access unpopulated location ?
It will be accessed though DT binding. As long as DT is correct, it
won't access unpopulated location.
With the Altera Avalon bus, even a unpopulated access will not stall.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] nios2: display altera sysid at startup
2015-12-16 13:44 ` Thomas Chou
@ 2015-12-16 14:01 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2015-12-16 14:01 UTC (permalink / raw)
To: u-boot
On Wednesday, December 16, 2015 at 02:44:04 PM, Thomas Chou wrote:
> Hi Marek,
>
> On 2015?12?16? 21:23, Marek Vasut wrote:
> > On Wednesday, December 16, 2015 at 02:10:26 PM, Thomas Chou wrote:
> >> Hi Marek,
> >
> > Hi!
> >
> >> On 2015?12?16? 18:25, Marek Vasut wrote:
> >>> On Wednesday, December 16, 2015 at 09:07:47 AM, Thomas Chou wrote:
> >>>> Display altera sysid at startup, which was once removed during
> >>>> the move.
> >>>>
> >>>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> >>>
> >>> What if the sysid block isn't part of the design ?
> >>
> >> If the sysid block is not present, nothing will display and it is not an
> >> error.
> >
> > Won't this cause bus stall if you try to access unpopulated location ?
>
> It will be accessed though DT binding. As long as DT is correct, it
> won't access unpopulated location.
>
> With the Altera Avalon bus, even a unpopulated access will not stall.
OK! Thanks for clarifying.
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-16 14:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-16 8:07 [U-Boot] [PATCH] nios2: display altera sysid at startup Thomas Chou
2015-12-16 10:25 ` Marek Vasut
2015-12-16 13:10 ` Thomas Chou
2015-12-16 13:23 ` Marek Vasut
2015-12-16 13:44 ` Thomas Chou
2015-12-16 14:01 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox