[U-Boot] [PATCH] eeprom: fix eeprom write procedure

Marek Vasut
2015-12-15T00:27:08Z

On Monday, December 14, 2015 at 04:45:34 PM, Alexey Brodkin wrote:
> This fixes commit 1a37889b0ad084a740b4f785031d7ae9955d947b:
> ----------------------->8--------------------
> eeprom: Pull out the RW loop
>
> Unify the code for doing read/write into single function, since the
> code for both the read and write is almost identical. This again
> trims down the code duplication.
> ----------------------->8--------------------
>
> where the same one routine is utilized for both EEPROM writing and
> reading. The only difference was supposed to be a "read" flag which
> in both cases was set with 1 somehow.
>
> That lead to a missing delay in case of writing which lead to write
> failure (in my case no data was written).
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Heiko Schocher <hs@denx.de>

Obviously correct,

Acked-by: Marek Vasut <marex@denx.de>

Thanks for spotting this, nice!

Best regards,
Marek Vasut