public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.
Date: Thu, 17 Dec 2015 04:46:55 +0100	[thread overview]
Message-ID: <201512170446.55816.marex@denx.de> (raw)
In-Reply-To: <tencent_69482D7B010BD104370EB028@qq.com>

On Thursday, December 17, 2015 at 04:25:28 AM, ShengjiangWu wrote:
> arm: socfpga: Fixed Phy not found error.
>                   Fixed QSPI flash not found error
>                   Disabled Hardware watch dog by default.
>                   Updated MMC clock.

Fix your mailer please.

>     Updated pinmux and clock for EMAC1 and QSPI flash.
>     U-BOOT-2015-10 can run on Cyclone V SoC Development
>     Kit (SoCDK) with this fix.
> 
>     Signed-off-by: swu <shengjiangwu@gmail.com>
>     Cc: Chin Liang See <clsee@altera.com>
>     Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
>     Cc: Dinh Nguyen <dinh.linux@gmail.com>
>     Cc: Pavel Machek <pavel@denx.de>
>     Cc: Marek Vasut <marex@denx.de>
>     Cc: Stefan Roese <sr@denx.de>

Please repost the patch using git send-email , details are at [1] and the 
process is very similar to Linux.

I briefly skimmed across the patch. I don't understand why do you replace
almost the entire pinmux just to fix ethernet issue. (ethernet works on
SoCDK I believe, which is another odd thing).

Furthermore, if you're fixing multiple things, split them into multiple
patches.

Finally, do not disable HW watchdog.

[1] www.denx.de/wiki/U-Boot/Patches

Best regards,
Marek Vasut

  reply	other threads:[~2015-12-17  3:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17  3:25 [U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock ShengjiangWu
2015-12-17  3:46 ` Marek Vasut [this message]
     [not found]   ` <tencent_161B2D19455B2D595272B82C@qq.com>
2015-12-17 14:58     ` Marek Vasut
2015-12-17  6:56 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201512170446.55816.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox