[U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

[U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

[ShengjiangWu]

arm: socfpga: Fixed Phy not found error.
                  Fixed QSPI flash not found error
                  Disabled Hardware watch dog by default.
                  Updated MMC clock.
    
    Updated pinmux and clock for EMAC1 and QSPI flash.
    U-BOOT-2015-10 can run on Cyclone V SoC Development
    Kit (SoCDK) with this fix.
    
    Signed-off-by: swu <shengjiangwu@gmail.com>
    Cc: Chin Liang See <clsee@altera.com>
    Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
    Cc: Dinh Nguyen <dinh.linux@gmail.com>
    Cc: Pavel Machek <pavel@denx.de>
    Cc: Marek Vasut <marex@denx.de>
    Cc: Stefan Roese <sr@denx.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-arm-socfpga-Fixed-Phy-not-found-error.patch
Type: application/octet-stream
Size: 8369 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151217/e08e555c/attachment.obj>

[U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

[Marek Vasut]

On Thursday, December 17, 2015 at 04:25:28 AM, ShengjiangWu wrote:
> arm: socfpga: Fixed Phy not found error.
>                   Fixed QSPI flash not found error
>                   Disabled Hardware watch dog by default.
>                   Updated MMC clock.

Fix your mailer please.

>     Updated pinmux and clock for EMAC1 and QSPI flash.
>     U-BOOT-2015-10 can run on Cyclone V SoC Development
>     Kit (SoCDK) with this fix.
> 
>     Signed-off-by: swu <shengjiangwu@gmail.com>
>     Cc: Chin Liang See <clsee@altera.com>
>     Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
>     Cc: Dinh Nguyen <dinh.linux@gmail.com>
>     Cc: Pavel Machek <pavel@denx.de>
>     Cc: Marek Vasut <marex@denx.de>
>     Cc: Stefan Roese <sr@denx.de>

Please repost the patch using git send-email , details are at [1] and the 
process is very similar to Linux.

I briefly skimmed across the patch. I don't understand why do you replace
almost the entire pinmux just to fix ethernet issue. (ethernet works on
SoCDK I believe, which is another odd thing).

Furthermore, if you're fixing multiple things, split them into multiple
patches.

Finally, do not disable HW watchdog.

[1] www.denx.de/wiki/U-Boot/Patches

Best regards,
Marek Vasut

[U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

[Marek Vasut]

On Thursday, December 17, 2015 at 07:59:34 AM, ShengjiangWu wrote:
> Hi Marek Vasut,

Hi,

> I will submit it later, thanks for your reminder.

Thanks.

Also, please do not top-post and please keep the entire Cc list intact.
Also keep the ML in the list.

> Best Regards
> Shengjiang Wu
> 
> 
> 
> 
> ------------------ Original ------------------
> From:  "marex";<marex@denx.de>;
> Date:  Thu, Dec 17, 2015 11:46 AM
> To:  "ShengjiangWu"<shengjiangwu@qq.com>;
> Cc:  "u-boot"<u-boot@lists.denx.de>;
> "shengjiangwu"<shengjiangwu@gmail.com>; "clsee"<clsee@altera.com>;
> "dinguyen"<dinguyen@opensource.altera.com>;
> "dinh.linux"<dinh.linux@gmail.com>; "pavel"<pavel@denx.de>;
> "sr"<sr@denx.de>; Subject:  Re: [PATCH] arm: socfpga: Fixed Phy not found
> error.               Fixed QSPI flash not found error              
> Disabled Hardware watch dog by default.               Updated MMC clock.
> 
> On Thursday, December 17, 2015 at 04:25:28 AM, ShengjiangWu wrote:
> > arm: socfpga: Fixed Phy not found error.
> > 
> >                   Fixed QSPI flash not found error
> >                   Disabled Hardware watch dog by default.
> >                   Updated MMC clock.
> 
> Fix your mailer please.
> 
> >     Updated pinmux and clock for EMAC1 and QSPI flash.
> >     U-BOOT-2015-10 can run on Cyclone V SoC Development
> >     Kit (SoCDK) with this fix.
> >     
> >     Signed-off-by: swu <shengjiangwu@gmail.com>
> >     Cc: Chin Liang See <clsee@altera.com>
> >     Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> >     Cc: Dinh Nguyen <dinh.linux@gmail.com>
> >     Cc: Pavel Machek <pavel@denx.de>
> >     Cc: Marek Vasut <marex@denx.de>
> >     Cc: Stefan Roese <sr@denx.de>
> 
> Please repost the patch using git send-email , details are at [1] and the
> process is very similar to Linux.
> 
> I briefly skimmed across the patch. I don't understand why do you replace
> almost the entire pinmux just to fix ethernet issue. (ethernet works on
> SoCDK I believe, which is another odd thing).
> 
> Furthermore, if you're fixing multiple things, split them into multiple
> patches.
> 
> Finally, do not disable HW watchdog.
> 
> [1] www.denx.de/wiki/U-Boot/Patches
> 
> Best regards,
> Marek Vasut

Best regards,
Marek Vasut

[U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

[Wolfgang Denk]

Dear Shengjiang Wu,

In message <tencent_69482D7B010BD104370EB028@qq.com> you wrote:
> 
| Subject: Re: [U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

Please move this information into the commit message; the Subject should
be short - some 60 characters or so, not more.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Above all else -- sky.