From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 00/11] zap: Do not use macros that are equivalent to IS_ENABLED(CONFIG_...)
Date: Fri, 18 Dec 2015 04:23:41 +0100 [thread overview]
Message-ID: <201512180423.41797.marex@denx.de> (raw)
In-Reply-To: <1450404310-20396-1-git-send-email-yamada.masahiro@socionext.com>
On Friday, December 18, 2015 at 03:04:59 AM, Masahiro Yamada wrote:
> Please stop such coding habit as follows:
>
> #ifdef CONFIG_FOO
> # define ENABLE_FOO 1
> #else
> # define ENABLE_FOO 0
> #endif
Oh yes, this is horrible, kill this with fire :)
> Use IS_ENABLED(CONFIG_FOO), instead.
>
>
>
> Masahiro Yamada (11):
> image: zap IMAGE_ENABLE_RAMDISK_HIGH
> image: zap IMAGE_ENABLE_OF_LIBFDT
> image: zap IMAGE_BOOT_GET_CMDLINE
> image: zap IMAGE_OF_BOARD_SETUP
> image: zap IMAGE_OF_SYSTEM_SETUP
> ARM: bootm: BOOTM_ENABLE_SERIAL_TAG
> ARM: bootm: BOOTM_ENABLE_CMDLINE_TAG
> ARM: bootm: BOOTM_ENABLE_REVISION_TAG
> ARM: bootm: BOOTM_ENABLE_MEMORY_TAG
> ARM: bootm: BOOTM_ENABLE_INITRD_TAG
> ARM: bootm: drop redundant #ifdef conditional
>
> arch/arc/lib/bootm.c | 2 +-
> arch/arm/include/asm/bootm.h | 22 ----------------------
> arch/arm/lib/bootm.c | 16 +++++++---------
> common/image-fdt.c | 6 +++---
> common/image.c | 10 +++++-----
> include/image.h | 30 ------------------------------
> 6 files changed, 16 insertions(+), 70 deletions(-)
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-12-18 3:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 2:04 [U-Boot] [PATCH 00/11] zap: Do not use macros that are equivalent to IS_ENABLED(CONFIG_...) Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 01/11] image: zap IMAGE_ENABLE_RAMDISK_HIGH Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 02/11] image: zap IMAGE_ENABLE_OF_LIBFDT Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 03/11] image: zap IMAGE_BOOT_GET_CMDLINE Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 04/11] image: zap IMAGE_OF_BOARD_SETUP Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 05/11] image: zap IMAGE_OF_SYSTEM_SETUP Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 06/11] ARM: bootm: BOOTM_ENABLE_SERIAL_TAG Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 07/11] ARM: bootm: BOOTM_ENABLE_CMDLINE_TAG Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 08/11] ARM: bootm: BOOTM_ENABLE_REVISION_TAG Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 09/11] ARM: bootm: BOOTM_ENABLE_MEMORY_TAG Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 10/11] ARM: bootm: BOOTM_ENABLE_INITRD_TAG Masahiro Yamada
2015-12-18 2:05 ` [U-Boot] [PATCH 11/11] ARM: bootm: drop redundant #ifdef conditional Masahiro Yamada
2015-12-18 3:23 ` Marek Vasut [this message]
2015-12-18 18:57 ` [U-Boot] [PATCH 00/11] zap: Do not use macros that are equivalent to IS_ENABLED(CONFIG_...) Simon Glass
2015-12-19 8:39 ` Masahiro Yamada
2015-12-19 20:29 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201512180423.41797.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox