public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: socfpga: Fix emac1 doesn't work on socdk board
Date: Fri, 18 Dec 2015 13:49:53 +0100	[thread overview]
Message-ID: <201512181349.53839.marex@denx.de> (raw)
In-Reply-To: <e622d4a6-79ff-4089-9750-86f72fac1373@me.com>

On Friday, December 18, 2015 at 09:50:09 AM, ?? ? wrote:
> On Dec 18, 2015, at 12:46 AM, Chin Liang See <clsee@altera.com> wrote:
> 
> Hi Shengjiang,
> 
> On Fri, 2015-12-18 at 16:43 +0800, shengjiangwu wrote:
> Updated pinmux group MIXED1IO[0-13] for RGMII1.
> Updated EMAC1 clock.
> 
> Signed-off-by: shengjiangwu <shengjiangwu@icloud.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Dinh Nguyen <dinh.linux@gmail.com>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> ---
> Changes for v2:
> - fixed wrong perpll for emac1
> ---
> board/altera/cyclone5-socdk/qts/pll_config.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/altera/cyclone5-socdk/qts/pll_config.h
> b/board/altera/cyclone5-socdk/qts/pll_config.h
> index eccc705..5b754ac 100644
> --- a/board/altera/cyclone5-socdk/qts/pll_config.h
> +++ b/board/altera/cyclone5-socdk/qts/pll_config.h
> @@ -65,7 +65,7 @@
> #define CONFIG_HPS_CLK_PERVCO_HZ 1000000000
> #define CONFIG_HPS_CLK_SDRVCO_HZ 666666666
> #define CONFIG_HPS_CLK_EMAC0_HZ 250000000
> -#define CONFIG_HPS_CLK_EMAC1_HZ 50000000
> +#define CONFIG_HPS_CLK_EMAC1_HZ 250000000
> 
> 
> This is good. But I believe you miss the pinmux change here. You just
> need to take the previous patch and made the change.
> 
> Thanks
> Chin Liang
> 
> Sorry for not familiar with re-patch process. 

Take a look at 'git rebase -i' and 'git commit --amend' and at the 'tig' command 
and then probably 'patchman' in the U-Boot source tree. These might be helpful.

Best regards,
Marek Vasut

  parent reply	other threads:[~2015-12-18 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18  8:50 [U-Boot] [PATCH v2] arm: socfpga: Fix emac1 doesn't work on socdk board 圣江 吴
2015-12-18  8:51 ` Chin Liang See
2015-12-18 12:49 ` Marek Vasut [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-12-18  8:43 shengjiangwu
2015-12-18  8:45 ` Chin Liang See

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201512181349.53839.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox