From: Antony Pavlov <antonynpavlov@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mips: add base support for atheros ar71xx based SOCs
Date: Fri, 18 Dec 2015 15:54:04 +0300 [thread overview]
Message-ID: <20151218155404.abbd4343f49ecc1f8af36949@gmail.com> (raw)
In-Reply-To: <BLU437-SMTP9890001EF32AAE5B07EE15FFE10@phx.gbl>
On Fri, 18 Dec 2015 15:34:29 +0800
Wills Wang <wills.wang@live.com> wrote:
> This patch enable work for ar933x SOC, tested on ar9331
>
> Signed-off-by: Wills Wang <wills.wang@live.com>
> ---
>
> arch/mips/Makefile | 1 +
> arch/mips/include/asm/ar71xx.h | 1144 +++++++++++++++++++++++++++
> arch/mips/mach-ath79/Makefile | 8 +
> arch/mips/mach-ath79/ar933x/Makefile | 11 +
> arch/mips/mach-ath79/ar933x/dram.c | 27 +
> arch/mips/mach-ath79/ar933x/lowlevel_init.S | 784 ++++++++++++++++++
> arch/mips/mach-ath79/ar933x/reset.c | 29 +
> arch/mips/mach-ath79/ar933x/serial.c | 348 ++++++++
> arch/mips/mach-ath79/config.mk | 8 +
> 9 files changed, 2360 insertions(+)
> create mode 100644 arch/mips/include/asm/ar71xx.h
> create mode 100644 arch/mips/mach-ath79/Makefile
> create mode 100644 arch/mips/mach-ath79/ar933x/Makefile
> create mode 100644 arch/mips/mach-ath79/ar933x/dram.c
> create mode 100644 arch/mips/mach-ath79/ar933x/lowlevel_init.S
> create mode 100644 arch/mips/mach-ath79/ar933x/reset.c
> create mode 100644 arch/mips/mach-ath79/ar933x/serial.c
> create mode 100644 arch/mips/mach-ath79/config.mk
1. Your lowlevel_init routine duplicates cache maintenance functions by Paul Burton
(please see commit 4a5d8898bca3e442b6 'MIPS: unify cache initialization code').
2. Can we select build for ar71xx from .config? I suppose 'No',
because the patch does not add any Kconfig option.
3. Can we put your arch/mips/mach-ath79/ar933x/serial.c into drivers/serial?
4. The patch is suffering from very very many unused macros in ar71xx.h.
5. The patch has whitespace errors, please see this git-am log:
Applying: mips: add base support for atheros ar71xx based SOCs
.git/rebase-apply/patch:1180: new blank line at EOF.
+
.git/rebase-apply/patch:2069: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
--?
Best regards,
? Antony Pavlov
next prev parent reply other threads:[~2015-12-18 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 7:34 [U-Boot] [PATCH] mips: add base support for atheros ar71xx based SOCs Wills Wang
2015-12-18 12:54 ` Antony Pavlov [this message]
2015-12-18 15:24 ` Wills Wang
2015-12-18 16:16 ` Antony Pavlov
2015-12-18 16:44 ` Wills Wang
2015-12-18 18:13 ` Antony Pavlov
2015-12-19 21:57 ` Daniel Schwierzeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218155404.abbd4343f49ecc1f8af36949@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox