public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] common: nvedit: use snprintf instead of sprintf
Date: Wed, 23 Dec 2015 11:00:30 +0800	[thread overview]
Message-ID: <20151223030028.GA24788@linux-7smt.suse> (raw)
In-Reply-To: <20151222194058.GW11783@bill-the-cat>

Hi All,
On Tue, Dec 22, 2015 at 02:40:58PM -0500, Tom Rini wrote:
>On Tue, Dec 22, 2015 at 07:53:12AM -0200, Fabio Estevam wrote:
>> Hi Peng,
>> 
>> On Tue, Dec 22, 2015 at 7:14 AM, Peng Fan <van.freenix@gmail.com> wrote:
>> > From: Peng Fan <peng.fan@nxp.com>
>> >
>> > Use snprintf to replace sprintf.
>> 
>> You need to improve your commit log by saying why you are doing this change.

will add more commit log.
>
>
>Yes, please do so.  And if you're using Coverity internally you can
>still do a Reported-by: Coverity.
will add this.

Thanks,
Peng.


>
>-- 
>Tom

  reply	other threads:[~2015-12-23  3:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22  9:14 [U-Boot] [PATCH 1/1] common: cli: avoid memory leak Peng Fan
2015-12-22  9:14 ` [U-Boot] [PATCH 1/1] common: env: initialize scalar variable Peng Fan
2015-12-22  9:29   ` Wolfgang Denk
2015-12-23  3:07     ` Peng Fan
2015-12-22  9:14 ` [U-Boot] [PATCH 1/1] common: nvedit: use snprintf instead of sprintf Peng Fan
2015-12-22  9:53   ` Fabio Estevam
2015-12-22 19:40     ` Tom Rini
2015-12-23  3:00       ` Peng Fan [this message]
2015-12-22 19:11   ` Joe Hershberger
2015-12-28  4:22 ` [U-Boot] [PATCH 1/1] common: cli: avoid memory leak Simon Glass
2015-12-28  5:12   ` Peng Fan
2016-01-04 19:59     ` Tom Rini
2016-01-04 22:23 ` [U-Boot] [U-Boot,1/1] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151223030028.GA24788@linux-7smt.suse \
    --to=van.freenix@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox