From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] common: env: initialize scalar variable
Date: Wed, 23 Dec 2015 11:07:23 +0800 [thread overview]
Message-ID: <20151223030722.GB24788@linux-7smt.suse> (raw)
In-Reply-To: <20151222092951.D2F8C383C2A@gemini.denx.de>
Hi Wolfgang
On Tue, Dec 22, 2015 at 10:29:51AM +0100, Wolfgang Denk wrote:
>Dear Peng Fan,
>
>In message <1450775655-2979-2-git-send-email-van.freenix@gmail.com> you wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Before calling hsearch_r, initialize callback entry to NULL.
>
>Which exact problem are you fixing here?
This was reported by Coverity.
"
Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value e. Field e.callback is uninitialized when calling hsearch_r.
"
I'll add more commit log in V2.
Regards,
Peng.
>
>Best regards,
>
>Wolfgang Denk
>
>--
>DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
>HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
>Beware of the Turing Tar-pit in which everything is possible but
>nothing of interest is easy.
next prev parent reply other threads:[~2015-12-23 3:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 9:14 [U-Boot] [PATCH 1/1] common: cli: avoid memory leak Peng Fan
2015-12-22 9:14 ` [U-Boot] [PATCH 1/1] common: env: initialize scalar variable Peng Fan
2015-12-22 9:29 ` Wolfgang Denk
2015-12-23 3:07 ` Peng Fan [this message]
2015-12-22 9:14 ` [U-Boot] [PATCH 1/1] common: nvedit: use snprintf instead of sprintf Peng Fan
2015-12-22 9:53 ` Fabio Estevam
2015-12-22 19:40 ` Tom Rini
2015-12-23 3:00 ` Peng Fan
2015-12-22 19:11 ` Joe Hershberger
2015-12-28 4:22 ` [U-Boot] [PATCH 1/1] common: cli: avoid memory leak Simon Glass
2015-12-28 5:12 ` Peng Fan
2016-01-04 19:59 ` Tom Rini
2016-01-04 22:23 ` [U-Boot] [U-Boot,1/1] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223030722.GB24788@linux-7smt.suse \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox