From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress
Date: Thu, 24 Dec 2015 04:02:24 +0100 [thread overview]
Message-ID: <201512240402.24738.marex@denx.de> (raw)
In-Reply-To: <567B5D91.6000903@wytron.com.tw>
On Thursday, December 24, 2015 at 03:50:57 AM, Thomas Chou wrote:
> Hi Marek,
>
> On 2015?12?24? 09:29, Marek Vasut wrote:
> > On Thursday, December 24, 2015 at 01:51:23 AM, Thomas Chou wrote:
> >> Show sector erase progress with dot and comma.
> >>
> >> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> >> ---
> >
> > Shouldn't this go into common code ?
>
> The code to print a dot is minimal. It will cost more if this go into
> common code.
But then this driver behaves in a non-standard manner AND noone benefits
from this functionality but this driver.
> Alternatively, we might set the flash_verbose directly and remove the
> flash_set_verbose().
>
> Best regards,
> Thomas
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-12-24 3:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 0:51 [U-Boot] [PATCH 1/5] altera_qspi: call callback even if the erase failed Thomas Chou
2015-12-24 0:51 ` [U-Boot] [PATCH 2/5] altera_qspi: set fail_addr for erase ops Thomas Chou
2015-12-28 1:34 ` Thomas Chou
2015-12-24 0:51 ` [U-Boot] [PATCH 3/5] altera_qspi: skip erase if the sector is blank Thomas Chou
2015-12-24 1:28 ` Marek Vasut
2015-12-24 2:23 ` Thomas Chou
2015-12-24 3:01 ` Marek Vasut
2015-12-24 3:08 ` Thomas Chou
2015-12-24 3:43 ` Marek Vasut
2015-12-28 1:34 ` Thomas Chou
2015-12-24 0:51 ` [U-Boot] [PATCH 4/5] altera_qspi: show erase progress Thomas Chou
2015-12-24 1:29 ` Marek Vasut
2015-12-24 2:50 ` Thomas Chou
2015-12-24 3:02 ` Marek Vasut [this message]
2015-12-24 3:26 ` Thomas Chou
2015-12-24 3:42 ` Marek Vasut
2015-12-24 5:24 ` Thomas Chou
2015-12-24 5:37 ` Marek Vasut
2015-12-25 0:12 ` Thomas Chou
2015-12-25 4:08 ` Marek Vasut
2015-12-25 8:33 ` Thomas Chou
2015-12-25 9:58 ` Marek Vasut
2015-12-28 1:17 ` Thomas Chou
2015-12-28 5:35 ` Marek Vasut
2015-12-28 8:04 ` Thomas Chou
2015-12-28 12:40 ` Marek Vasut
2015-12-28 1:35 ` Thomas Chou
2015-12-24 0:51 ` [U-Boot] [PATCH 5/5] altera_qspi: allow ctrl-c to abort the erase ops Thomas Chou
2015-12-28 1:35 ` Thomas Chou
2015-12-28 1:34 ` [U-Boot] [PATCH 1/5] altera_qspi: call callback even if the erase failed Thomas Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201512240402.24738.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox