[U-Boot] [PATCH v4 6/8] mips: ath79: add AP121 reference board

Marek Vasut
2015-12-27T06:41:41Z

On Sunday, December 27, 2015 at 07:36:00 AM, Wills Wang wrote:
> On 12/26/2015 09:52 PM, Daniel Schwierzeck wrote:
> > Am 25.12.2015 um 19:56 schrieb Wills Wang:
> >> Signed-off-by: Wills Wang <wills.wang@live.com>

[...]

> >> diff --git a/configs/ap121_defconfig b/configs/ap121_defconfig
> >> new file mode 100644
> >> index 0000000..cec0bb7
> >> --- /dev/null
> >> +++ b/configs/ap121_defconfig
> >> @@ -0,0 +1,42 @@
> >> +CONFIG_MIPS=y
> >> +CONFIG_TARGET_AP121=y
> >> +CONFIG_SYS_MALLOC_F_LEN=0x2000
> >> +CONFIG_SYS_PROMPT="ap121 # "
> >> +CONFIG_OF_CONTROL=y
> >> +CONFIG_DEFAULT_DEVICE_TREE="ap121"
> >> +CONFIG_DM=y
> >
> > options like CONFIG_OF_CONTROL and CONFIG_DM should be pre-selected by
> > the mach or SoC specific Kconfig file if you always require it. An user
> > of your board should not be able to disable those options.
> >
> >> +CONFIG_DM_SERIAL=y
> >> +CONFIG_DM_SPI=y
> >> +CONFIG_DM_SPI_FLASH=y
> >> +CONFIG_ATH79_SPI=y
> >> +CONFIG_SPI_FLASH=y
> >> +CONFIG_SPI_FLASH_BAR=y
> >> +CONFIG_SPI_FLASH_ATMEL=y
> >> +CONFIG_SPI_FLASH_EON=y
> >> +CONFIG_SPI_FLASH_GIGADEVICE=y
> >> +CONFIG_SPI_FLASH_MACRONIX=y
> >> +CONFIG_SPI_FLASH_SPANSION=y
> >> +CONFIG_SPI_FLASH_STMICRO=y
> >> +CONFIG_SPI_FLASH_SST=y
> >> +CONFIG_SPI_FLASH_WINBOND=y
> >> +CONFIG_SPI_FLASH_USE_4K_SECTORS=y
> >> +CONFIG_SPI_FLASH_DATAFLASH=y
> >> +CONFIG_SPI_FLASH_MTD=y
> >> +CONFIG_CMD_DM=y
> >> +CONFIG_CMD_SF=y
> >> +CONFIG_CMD_SPI=y
> >> +# CONFIG_NET is not set
> >> +# CONFIG_CMD_BDI is not set
> >> +# CONFIG_CMD_CONSOLE is not set
> >> +# CONFIG_CMD_IMLS is not set
> >> +# CONFIG_CMD_XIMG is not set
> >> +# CONFIG_CMD_ELF is not set
> >> +# CONFIG_CMD_EXPORTENV is not set
> >> +# CONFIG_CMD_IMPORTENV is not set
> >> +# CONFIG_CMD_EDITENV is not set
> >> +# CONFIG_CMD_CRC32 is not set
> >> +# CONFIG_CMD_FLASH is not set
> >> +# CONFIG_CMD_FPGA is not set
> >> +# CONFIG_CMD_NFS is not set
> >> +# CONFIG_CMD_NET is not set
> >> +CONFIG_USE_PRIVATE_LIBGCC=y

Why is private libgcc enabled here ? Is your toolchain buggy ?

> >> diff --git a/include/configs/ap121.h b/include/configs/ap121.h
> >> new file mode 100644
> >> index 0000000..5a01d11
> >> --- /dev/null
> >> +++ b/include/configs/ap121.h
> >> @@ -0,0 +1,82 @@
> >> +#ifndef __CONFIG_H
> >> +#define __CONFIG_H
> >> +
> >> +#include <linux/kconfig.h>
> >> +#include <linux/sizes.h>
> >
> > those includes are not needed in a board config header file respectively
> > they are already included implicitely
> >
> >> +
> >> +#define CONFIG_ARCH_ATH79
> >> +#define CONFIG_SOC_AR933X
> >
> > this is already configured by Kconfig
> >
> >> +
> >> +#define CONFIG_DISPLAY_CPUINFO
> >> +#define CONFIG_DISPLAY_BOARDINFO
> >> +
> >> +#define CONFIG_OF_LIBFDT
> >> +
> >> +#define CONFIG_SYS_HZ 1000
> >> +#define CONFIG_SYS_MHZ 200
> >> +#define CONFIG_SYS_MIPS_TIMER_FREQ (CONFIG_SYS_MHZ * 1000000)
> >> +
> >> +/* Cache Configuration */
> >> +#define CONFIG_SYS_DCACHE_SIZE 32 * SZ_1K
> >> +#define CONFIG_SYS_ICACHE_SIZE 64 * SZ_1K
> >> +#define CONFIG_SYS_CACHELINE_SIZE 32
> >
> > you can drop this, the cache sizes will be detected automatically
>
> My board don't boot up if drop this.

btw please use the [...] to trim your reply to relevant parts only, it's
often real hard to find the relevant one-liner reply in a sea of quoted
text. …