public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] spl: dm: Add SPL_DM_SEQ_ALIAS config option
Date: Wed, 30 Dec 2015 10:02:29 +0100	[thread overview]
Message-ID: <201512301002.29297.marex@denx.de> (raw)
In-Reply-To: <CA+aJhH29bv6adGqutC6iCA0grvd1Uje-nH1bOSTLGuz2ApN9zg@mail.gmail.com>

On Wednesday, December 30, 2015 at 06:52:24 AM, Nathan Rossi wrote:
[...]
> > TBH I don't think this is the best solution. We should select things
> > which are required all the time. For zynq case this selection is
> > necessary just for qspi boot mode. There are other boot modes which
> > doesn't require it that's why for these mods this is just additional
> > code. If you think that this is need/good to select by default for your
> > SoC then this can be done separately.
> 
> Sorry for the slow response/follow up on this.
> 
> So as I understand it makes sense for this to be configured slightly
> differently depending on when the boot options that need this are
> available. I guess this also makes sense as SPI is not the only user
> of the seq alias feature.
> 
> I am sorting out v2 of this series for the additional patches to add
> the config for socfpga and mvebu, just want to clarify that this would
> be the preferred way (given recent comments) to enable it for the
> corresponding platforms:
>  * socfpga -> enable in each defconfig

If the feature is imperative for the platform to work, just enable it in
Kconfig too, just like on mvebu.

>  * mvebu -> enable in arch/arm/Kconfig for ARCH_MVEBU (aka auto selecting)
> 
> > Note: Agree with Marek that will be good to check where exactly the
> > problem is that this config option is necessary to enable even for case
> > where only on qspi is in the system.
> 
> I had a bit of a look into this, it would require changes to allow for
> it to fall-back to finding and using the first device which is matched
> for the uclass (instead of relying on just CONFIG_SF_DEFAULT_BUS), it
> would probably be an intrusive change to sf-uclass. A simpler solution
> might be to just default seq numbers to 0 when seq alias is not
> enabled? would allow for the change to work with other uclasses that
> use seq alias.
> 
> Regards,
> Nathan
> 
> > Acked-by: Michal Simek <michal.simek@xilinx.com>
> > 
> > Thanks,
> > Michal

Best regards,
Marek Vasut

  reply	other threads:[~2015-12-30  9:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 14:48 [U-Boot] [PATCH 0/2] Change DM_SEQ_ALIAS to be configurable for SPL Nathan Rossi
2015-12-11 14:48 ` [U-Boot] [PATCH 1/2] spl: dm: Add SPL_DM_SEQ_ALIAS config option Nathan Rossi
2015-12-11 15:07   ` Marek Vasut
2015-12-11 15:46     ` Michal Simek
2015-12-11 17:32       ` Marek Vasut
2015-12-12 12:05         ` Stefan Roese
2015-12-12 14:08           ` Nathan Rossi
2015-12-12 15:38             ` Marek Vasut
2015-12-14  6:26             ` Stefan Roese
2015-12-14  7:29               ` Michal Simek
2015-12-30  5:52                 ` Nathan Rossi
2015-12-30  9:02                   ` Marek Vasut [this message]
2015-12-11 15:47   ` Simon Glass
2015-12-11 14:48 ` [U-Boot] [PATCH 2/2] arm: zynq: Enable SPL_DM_SEQ_ALIAS for all Zynq configs Nathan Rossi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201512301002.29297.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox