From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sun, 3 Jan 2016 10:56:43 -0500 Subject: [U-Boot] Pull request: u-boot-spi/next In-Reply-To: References: <1451471464-12899-1-git-send-email-jteki@openedev.com> <20160102170432.GU4093@bill-the-cat> <20160103144416.GX4093@bill-the-cat> Message-ID: <20160103155643.GY4093@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Jan 03, 2016 at 09:10:14PM +0530, Jagan Teki wrote: > On 3 January 2016 at 20:14, Tom Rini wrote: > > On Sun, Jan 03, 2016 at 09:26:38AM +0530, Jagan Teki wrote: > >> On 2 January 2016 at 22:34, Tom Rini wrote: > >> > On Wed, Dec 30, 2015 at 04:04:23PM +0530, Jagan Teki wrote: > >> > > >> >> Tom, > >> >> > >> >> Please note that subject shows u-boot-spi/next but it actually > >> >> u-boot-spi/master and of course PR shows the repo as master (not > >> >> next). > >> > > >> > OK, what in here is a clear bugfix rather than new feature that we > >> > should have taken in sooner? As-is this needs some rework on samsung > >> > stuff to make trats, trats2 and s5pc210_universal work. Thanks! > >> > >> How come these sf and ti patches are blocking these samsung boards to > >> work? few of these were bug fixes and others were features (ti > >> patches) but those initiated in last MW. > > > > The patch to use BIT() in spi.h causes undefined references on trats2, > > hence the first patch I posted in reply to the PR. This however broke > > trats/s5pc210_universal. > > Build looks fine for me [1] > > [1] http://paste.ubuntu.com/14387171/ Yes, that and trats are fine with your series, trats2 is not. My first pass at fixing trats2 broke trats/s5p.. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: