* [U-Boot] [PATCH] Fix compile error when CONFIG_UBI_SILENCE_MSG defined
@ 2015-12-30 1:43 Ladislav Michl
2016-01-03 21:05 ` [U-Boot] [PATCH] UBI: " Ladislav Michl
0 siblings, 1 reply; 4+ messages in thread
From: Ladislav Michl @ 2015-12-30 1:43 UTC (permalink / raw)
To: u-boot
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
drivers/mtd/ubi/io.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
index d1bdec3..0be9c5a 100644
--- a/drivers/mtd/ubi/io.c
+++ b/drivers/mtd/ubi/io.c
@@ -1351,7 +1351,6 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
ubi_err(ubi, "self-check failed for PEB %d:%d, len %d",
pnum, offset, len);
ubi_msg(ubi, "data differ at position %d", i);
- dump_len = max_t(int, 128, len - i);
ubi_msg(ubi, "hex dump of the original buffer from %d to %d",
i, i + dump_len);
print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] UBI: Fix compile error when CONFIG_UBI_SILENCE_MSG defined
2015-12-30 1:43 [U-Boot] [PATCH] Fix compile error when CONFIG_UBI_SILENCE_MSG defined Ladislav Michl
@ 2016-01-03 21:05 ` Ladislav Michl
2016-01-04 7:04 ` Heiko Schocher
2016-01-04 8:12 ` Heiko Schocher
0 siblings, 2 replies; 4+ messages in thread
From: Ladislav Michl @ 2016-01-03 21:05 UTC (permalink / raw)
To: u-boot
drivers/mtd/ubi/io.c:1354:3: error: 'dump_len' undeclared (first use in
this function)
dump_len = max_t(int, 128, len - i);
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
drivers/mtd/ubi/io.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
index d1bdec3..0be9c5a 100644
--- a/drivers/mtd/ubi/io.c
+++ b/drivers/mtd/ubi/io.c
@@ -1351,7 +1351,6 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
ubi_err(ubi, "self-check failed for PEB %d:%d, len %d",
pnum, offset, len);
ubi_msg(ubi, "data differ at position %d", i);
- dump_len = max_t(int, 128, len - i);
ubi_msg(ubi, "hex dump of the original buffer from %d to %d",
i, i + dump_len);
print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] UBI: Fix compile error when CONFIG_UBI_SILENCE_MSG defined
2016-01-03 21:05 ` [U-Boot] [PATCH] UBI: " Ladislav Michl
@ 2016-01-04 7:04 ` Heiko Schocher
2016-01-04 8:12 ` Heiko Schocher
1 sibling, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2016-01-04 7:04 UTC (permalink / raw)
To: u-boot
Hello Ladislav Michl
Am 03.01.2016 um 22:05 schrieb Ladislav Michl:
> drivers/mtd/ubi/io.c:1354:3: error: 'dump_len' undeclared (first use in
> this function)
> dump_len = max_t(int, 128, len - i);
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
> drivers/mtd/ubi/io.c | 1 -
> 1 file changed, 1 deletion(-)
You sended this patch twice? Old version here:
http://patchwork.ozlabs.org/patch/561670/
removed this patch from patchwork.
bye,
Heiko
>
> diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
> index d1bdec3..0be9c5a 100644
> --- a/drivers/mtd/ubi/io.c
> +++ b/drivers/mtd/ubi/io.c
> @@ -1351,7 +1351,6 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
> ubi_err(ubi, "self-check failed for PEB %d:%d, len %d",
> pnum, offset, len);
> ubi_msg(ubi, "data differ at position %d", i);
> - dump_len = max_t(int, 128, len - i);
> ubi_msg(ubi, "hex dump of the original buffer from %d to %d",
> i, i + dump_len);
> print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] UBI: Fix compile error when CONFIG_UBI_SILENCE_MSG defined
2016-01-03 21:05 ` [U-Boot] [PATCH] UBI: " Ladislav Michl
2016-01-04 7:04 ` Heiko Schocher
@ 2016-01-04 8:12 ` Heiko Schocher
1 sibling, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2016-01-04 8:12 UTC (permalink / raw)
To: u-boot
Hello Ladislav Michl,
Am 03.01.2016 um 22:05 schrieb Ladislav Michl:
> drivers/mtd/ubi/io.c:1354:3: error: 'dump_len' undeclared (first use in
> this function)
> dump_len = max_t(int, 128, len - i);
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
> drivers/mtd/ubi/io.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks!
Applied to u-boot-ubi.git
bye,
Heiko
>
> diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
> index d1bdec3..0be9c5a 100644
> --- a/drivers/mtd/ubi/io.c
> +++ b/drivers/mtd/ubi/io.c
> @@ -1351,7 +1351,6 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
> ubi_err(ubi, "self-check failed for PEB %d:%d, len %d",
> pnum, offset, len);
> ubi_msg(ubi, "data differ at position %d", i);
> - dump_len = max_t(int, 128, len - i);
> ubi_msg(ubi, "hex dump of the original buffer from %d to %d",
> i, i + dump_len);
> print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-04 8:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-30 1:43 [U-Boot] [PATCH] Fix compile error when CONFIG_UBI_SILENCE_MSG defined Ladislav Michl
2016-01-03 21:05 ` [U-Boot] [PATCH] UBI: " Ladislav Michl
2016-01-04 7:04 ` Heiko Schocher
2016-01-04 8:12 ` Heiko Schocher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox