From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pfuze: Fix unsigned variable for less-than-zero comparison
Date: Mon, 4 Jan 2016 16:57:58 +0800 [thread overview]
Message-ID: <20160104085756.GA11833@linux-7smt.suse> (raw)
In-Reply-To: <568A364D.3030406@denx.de>
Hi Stefano,
On Mon, Jan 04, 2016 at 10:07:25AM +0100, Stefano Babic wrote:
>Hi Peng,
>
>On 04/01/2016 08:26, Peng Fan wrote:
>> From: "Ye.Li" <B37916@freescale.com>
>>
>
>it is enough to have Ye in the Signed-off instead of the commit message.
Since author is not me, but patch sent out from me. I think git add that
automatically. "git am" will not add this in commit message.
Regards,
Peng.
>
>> According to the Coverity result, a unsigned int variable is used fo less-
>> than-zero comparison, the result is never true. Need to fix the variable
>> type to signed int.
>>
>> Signed-off-by: Ye.Li <B37916@freescale.com>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> ---
>> board/freescale/common/pfuze.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/board/freescale/common/pfuze.c b/board/freescale/common/pfuze.c
>> index 783c46d..69afa83 100644
>> --- a/board/freescale/common/pfuze.c
>> +++ b/board/freescale/common/pfuze.c
>> @@ -13,7 +13,8 @@
>> int pfuze_mode_init(struct pmic *p, u32 mode)
>> {
>> unsigned char offset, i, switch_num;
>> - u32 id, ret;
>> + u32 id;
>> + int ret;
>>
>> pmic_reg_read(p, PFUZE100_DEVICEID, &id);
>> id = id & 0xf;
>>
>
>Apart of that:
>
>Reviewed-by: Stefano Babic <sbabic@denx.de>
>
>Best regards,
>Stefano Babic
>
>
>--
>=====================================================================
>DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
>HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
>=====================================================================
next prev parent reply other threads:[~2016-01-04 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 7:26 [U-Boot] [PATCH] pfuze: Fix unsigned variable for less-than-zero comparison Peng Fan
2016-01-04 9:07 ` Stefano Babic
2016-01-04 8:57 ` Peng Fan [this message]
2016-01-07 16:49 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104085756.GA11833@linux-7smt.suse \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox