public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/2] imx: spl: enable CONFIG_SPL_WATCHDOG_SUPPORT
Date: Mon, 4 Jan 2016 20:40:10 +0800	[thread overview]
Message-ID: <20160104124007.GA28726@linux-7smt.suse> (raw)
In-Reply-To: <201601041338.23299.marex@denx.de>

Hi Marek,
On Mon, Jan 04, 2016 at 01:38:23PM +0100, Marek Vasut wrote:
>On Monday, January 04, 2016 at 01:27:27 PM, Peng Fan wrote:
>> This commit 4bdcbe60a142b08eefccb0e326a37ba81d3389e8 removes reset_cpu
>> which breaks SPL build when DEBUG macro defined.
>> 
>> "
>> arch/arm/lib/built-in.o: In function `do_reset':
>> ~/uboot/arch/arm/lib/reset.c:45: undefined reference to `reset_cpu'
>> scripts/Makefile.spl:244: recipe for target 'spl/u-boot-spl' failed
>> "
>> Enable CONFIG_SPL_WATCHDOG_SUPPORT to fix this issue.
>
>Why don't you implement dummy reset_cpu() {} instead ?

Do you mean this, https://patchwork.ozlabs.org/patch/562232/?

Regards,
Peng

>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>> Cc: Marek Vasut <marex@denx.de>
>> Cc: Tim Harvey <tharvey@gateworks.com>
>> ---
>>  include/configs/imx6_spl.h | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h
>> index 43ce7fe..68d3fd7 100644
>> --- a/include/configs/imx6_spl.h
>> +++ b/include/configs/imx6_spl.h
>> @@ -34,6 +34,7 @@
>>  #define CONFIG_SPL_SERIAL_SUPPORT
>>  #define CONFIG_SPL_I2C_SUPPORT
>>  #define CONFIG_SPL_GPIO_SUPPORT
>> +#define CONFIG_SPL_WATCHDOG_SUPPORT
>> 
>>  /* NAND support */
>>  #if defined(CONFIG_SPL_NAND_SUPPORT)
>
>Best regards,
>Marek Vasut

  reply	other threads:[~2016-01-04 12:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 12:27 [U-Boot] [PATCH V2 1/2] imx: spl: enable CONFIG_SPL_WATCHDOG_SUPPORT Peng Fan
2016-01-04 12:27 ` [U-Boot] [PATCH V2 2/2] imx: mx6ul: disable VIDEO for SPL Peng Fan
2016-01-04 12:31 ` [U-Boot] [PATCH V2 1/2] imx: spl: enable CONFIG_SPL_WATCHDOG_SUPPORT Eric Nelson
2016-01-04 12:38 ` Marek Vasut
2016-01-04 12:40   ` Peng Fan [this message]
2016-01-04 12:45     ` Marek Vasut
2016-01-04 12:49       ` Peng Fan
2016-01-04 12:57       ` Stefano Babic
2016-01-04 13:23         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160104124007.GA28726@linux-7smt.suse \
    --to=van.freenix@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox