From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Mon, 4 Jan 2016 20:40:10 +0800 Subject: [U-Boot] [PATCH V2 1/2] imx: spl: enable CONFIG_SPL_WATCHDOG_SUPPORT In-Reply-To: <201601041338.23299.marex@denx.de> References: <1451910448-28192-1-git-send-email-peng.fan@nxp.com> <201601041338.23299.marex@denx.de> Message-ID: <20160104124007.GA28726@linux-7smt.suse> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On Mon, Jan 04, 2016 at 01:38:23PM +0100, Marek Vasut wrote: >On Monday, January 04, 2016 at 01:27:27 PM, Peng Fan wrote: >> This commit 4bdcbe60a142b08eefccb0e326a37ba81d3389e8 removes reset_cpu >> which breaks SPL build when DEBUG macro defined. >> >> " >> arch/arm/lib/built-in.o: In function `do_reset': >> ~/uboot/arch/arm/lib/reset.c:45: undefined reference to `reset_cpu' >> scripts/Makefile.spl:244: recipe for target 'spl/u-boot-spl' failed >> " >> Enable CONFIG_SPL_WATCHDOG_SUPPORT to fix this issue. > >Why don't you implement dummy reset_cpu() {} instead ? Do you mean this, https://patchwork.ozlabs.org/patch/562232/? Regards, Peng > >> Signed-off-by: Peng Fan >> Cc: Stefano Babic >> Cc: Fabio Estevam >> Cc: Marek Vasut >> Cc: Tim Harvey >> --- >> include/configs/imx6_spl.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h >> index 43ce7fe..68d3fd7 100644 >> --- a/include/configs/imx6_spl.h >> +++ b/include/configs/imx6_spl.h >> @@ -34,6 +34,7 @@ >> #define CONFIG_SPL_SERIAL_SUPPORT >> #define CONFIG_SPL_I2C_SUPPORT >> #define CONFIG_SPL_GPIO_SUPPORT >> +#define CONFIG_SPL_WATCHDOG_SUPPORT >> >> /* NAND support */ >> #if defined(CONFIG_SPL_NAND_SUPPORT) > >Best regards, >Marek Vasut