From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/2] imx: spl: enable CONFIG_SPL_WATCHDOG_SUPPORT
Date: Mon, 4 Jan 2016 20:49:08 +0800 [thread overview]
Message-ID: <20160104124906.GB28726@linux-7smt.suse> (raw)
In-Reply-To: <201601041345.49201.marex@denx.de>
On Mon, Jan 04, 2016 at 01:45:49PM +0100, Marek Vasut wrote:
>On Monday, January 04, 2016 at 01:40:10 PM, Peng Fan wrote:
>> Hi Marek,
>>
>> On Mon, Jan 04, 2016 at 01:38:23PM +0100, Marek Vasut wrote:
>> >On Monday, January 04, 2016 at 01:27:27 PM, Peng Fan wrote:
>> >> This commit 4bdcbe60a142b08eefccb0e326a37ba81d3389e8 removes reset_cpu
>> >> which breaks SPL build when DEBUG macro defined.
>> >>
>> >> "
>> >> arch/arm/lib/built-in.o: In function `do_reset':
>> >> ~/uboot/arch/arm/lib/reset.c:45: undefined reference to `reset_cpu'
>> >> scripts/Makefile.spl:244: recipe for target 'spl/u-boot-spl' failed
>> >> "
>> >> Enable CONFIG_SPL_WATCHDOG_SUPPORT to fix this issue.
>> >
>> >Why don't you implement dummy reset_cpu() {} instead ?
>>
>> Do you mean this, https://patchwork.ozlabs.org/patch/562232/?
>
>Yes, I'd prefer that, since I do not want to see watchdog support becoming
>mandatory part of the SPL build. Watchdog support should be optional.
Wait for Stefano's comments on this -:)
Regards,
Peng.
>
>Best regards,
>Marek Vasut
next prev parent reply other threads:[~2016-01-04 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 12:27 [U-Boot] [PATCH V2 1/2] imx: spl: enable CONFIG_SPL_WATCHDOG_SUPPORT Peng Fan
2016-01-04 12:27 ` [U-Boot] [PATCH V2 2/2] imx: mx6ul: disable VIDEO for SPL Peng Fan
2016-01-04 12:31 ` [U-Boot] [PATCH V2 1/2] imx: spl: enable CONFIG_SPL_WATCHDOG_SUPPORT Eric Nelson
2016-01-04 12:38 ` Marek Vasut
2016-01-04 12:40 ` Peng Fan
2016-01-04 12:45 ` Marek Vasut
2016-01-04 12:49 ` Peng Fan [this message]
2016-01-04 12:57 ` Stefano Babic
2016-01-04 13:23 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104124906.GB28726@linux-7smt.suse \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox