From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 4 Jan 2016 13:45:49 +0100 Subject: [U-Boot] [PATCH V2 1/2] imx: spl: enable CONFIG_SPL_WATCHDOG_SUPPORT In-Reply-To: <20160104124007.GA28726@linux-7smt.suse> References: <1451910448-28192-1-git-send-email-peng.fan@nxp.com> <201601041338.23299.marex@denx.de> <20160104124007.GA28726@linux-7smt.suse> Message-ID: <201601041345.49201.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, January 04, 2016 at 01:40:10 PM, Peng Fan wrote: > Hi Marek, > > On Mon, Jan 04, 2016 at 01:38:23PM +0100, Marek Vasut wrote: > >On Monday, January 04, 2016 at 01:27:27 PM, Peng Fan wrote: > >> This commit 4bdcbe60a142b08eefccb0e326a37ba81d3389e8 removes reset_cpu > >> which breaks SPL build when DEBUG macro defined. > >> > >> " > >> arch/arm/lib/built-in.o: In function `do_reset': > >> ~/uboot/arch/arm/lib/reset.c:45: undefined reference to `reset_cpu' > >> scripts/Makefile.spl:244: recipe for target 'spl/u-boot-spl' failed > >> " > >> Enable CONFIG_SPL_WATCHDOG_SUPPORT to fix this issue. > > > >Why don't you implement dummy reset_cpu() {} instead ? > > Do you mean this, https://patchwork.ozlabs.org/patch/562232/? Yes, I'd prefer that, since I do not want to see watchdog support becoming mandatory part of the SPL build. Watchdog support should be optional. Best regards, Marek Vasut