[U-Boot] [PULL] u-boot-usb/master

Marek Vasut
2017-09-23T17:44:29Z

On 09/23/2017 07:39 PM, Tom Rini wrote:
> On Sat, Sep 23, 2017 at 07:32:31PM +0200, Marek Vasut wrote:
>> On 09/23/2017 06:11 PM, Tom Rini wrote:
>>> On Sat, Sep 23, 2017 at 03:14:20PM +0200, Marek Vasut wrote:
>>>
>>>> The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5:
>>>>
>>>> Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)
>>>>
>>>> are available in the git repository at:
>>>>
>>>> git://git.denx.de/u-boot-usb.git master
>>>>
>>>> for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:
>>>>
>>>> usb: xhci: Set 'Average TRB Length' to 8 for control endpoints
>>>> (2017-09-23 15:12:29 +0200)
>>>>
>>>
>>> git bisect says that:
>>> commit 5c45fbd38ecd6388f6d3ee1e07126b17d7e0c6b3
>>> Author: Bin Meng <bmeng.cn@gmail.com>
>>> Date: Mon Sep 18 06:40:37 2017 -0700
>>>
>>> dm: usb: Fix broken usb_stop()
>>>
>>> breaks 'make tests'.
>>
>> Unfortunately, for me the bisect points to:
>> commit 2fa73e784da105419b7d9d07d8f9d4a79afe531a
>> Author: Tom Rini <trini@konsulko.com>
>> Date: Fri Sep 15 13:15:25 2017 -0400
>>
>> Makefile: Update minimum dtc version to 1.4.3
>>
>> With support for overlays and calling the -@ flag to dtc we need to have
>> at least 1.4.3 available now.
>>
>> Cc: Simon Glass <sjg@chromium.org>
>> Reported-by: Stephen Warren <swarren@wwwdotorg.org>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>
>> And it is broken on EVERY debian system, since every debian system ships
>> with DTC 1.4.2 or older:
>> https://packages.debian.org/search?keywords=device-tree-compiler
>
> Please make sure that you submit your pull requests to travis-ci before
> sending them to me. And I'm not trying to single you out here, we have
> a whole bunch of automated CI and I do get a little cranky when we hit
> problems that the tools catch.
>
> And yes, sure, don't submit PRs you're absolutely sure won't have
> problems that CI would have caught (like the SoCFPGA one) or when you've
> locally run all of the relevant tests yourself.
>
Clearly, travis does not catch "u-boot does not build for any debian
system" this time.

--
Best regards,
Marek Vasut