* [U-Boot] [PATCH] net: remove scary warning about EEPROM provided MAC address
@ 2016-01-04 15:48 Andre Przywara
2016-01-04 15:52 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andre Przywara @ 2016-01-04 15:48 UTC (permalink / raw)
To: u-boot
In many parts of the computing world having a unique MAC address
sitting in some on-NIC storage is considered the normal case.
Remove the warning to not scare the user unnecessarily.
This applies to Highbank/Midway and ARM's Juno, for instance.
Besides that this fixes the formatting on Midway, for instance,
which currently looks like:
...
Net: xgmac0
Warning: xgmac0 using MAC address from net device
, xgmac1
Warning: xgmac1 using MAC address from net device
...
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
net/eth.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/eth.c b/net/eth.c
index 6cf3a35..a1b8abc 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -761,8 +761,6 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name,
} else if (is_valid_ethaddr(dev->enetaddr)) {
eth_setenv_enetaddr_by_index(base_name, eth_number,
dev->enetaddr);
- printf("\nWarning: %s using MAC address from net device\n",
- dev->name);
} else if (is_zero_ethaddr(dev->enetaddr)) {
#ifdef CONFIG_NET_RANDOM_ETHADDR
net_random_ethaddr(dev->enetaddr);
--
2.6.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] net: remove scary warning about EEPROM provided MAC address
2016-01-04 15:48 [U-Boot] [PATCH] net: remove scary warning about EEPROM provided MAC address Andre Przywara
@ 2016-01-04 15:52 ` Tom Rini
2016-01-09 3:35 ` [U-Boot] " Tom Rini
2016-01-26 15:02 ` [U-Boot] [PATCH] " Joe Hershberger
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2016-01-04 15:52 UTC (permalink / raw)
To: u-boot
On Mon, Jan 04, 2016 at 03:48:22PM +0000, Andre Przywara wrote:
> In many parts of the computing world having a unique MAC address
> sitting in some on-NIC storage is considered the normal case.
> Remove the warning to not scare the user unnecessarily.
> This applies to Highbank/Midway and ARM's Juno, for instance.
> Besides that this fixes the formatting on Midway, for instance,
> which currently looks like:
> ...
> Net: xgmac0
> Warning: xgmac0 using MAC address from net device
> , xgmac1
> Warning: xgmac1 using MAC address from net device
> ...
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160104/c78e1c52/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] net: remove scary warning about EEPROM provided MAC address
2016-01-04 15:48 [U-Boot] [PATCH] net: remove scary warning about EEPROM provided MAC address Andre Przywara
2016-01-04 15:52 ` Tom Rini
@ 2016-01-09 3:35 ` Tom Rini
2016-01-26 15:02 ` [U-Boot] [PATCH] " Joe Hershberger
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2016-01-09 3:35 UTC (permalink / raw)
To: u-boot
On Mon, Jan 04, 2016 at 03:48:22PM +0000, Andre Przywara wrote:
> In many parts of the computing world having a unique MAC address
> sitting in some on-NIC storage is considered the normal case.
> Remove the warning to not scare the user unnecessarily.
> This applies to Highbank/Midway and ARM's Juno, for instance.
> Besides that this fixes the formatting on Midway, for instance,
> which currently looks like:
> ...
> Net: xgmac0
> Warning: xgmac0 using MAC address from net device
> , xgmac1
> Warning: xgmac1 using MAC address from net device
> ...
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160108/2173ddae/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] net: remove scary warning about EEPROM provided MAC address
2016-01-04 15:48 [U-Boot] [PATCH] net: remove scary warning about EEPROM provided MAC address Andre Przywara
2016-01-04 15:52 ` Tom Rini
2016-01-09 3:35 ` [U-Boot] " Tom Rini
@ 2016-01-26 15:02 ` Joe Hershberger
2 siblings, 0 replies; 4+ messages in thread
From: Joe Hershberger @ 2016-01-26 15:02 UTC (permalink / raw)
To: u-boot
On Mon, Jan 4, 2016 at 9:48 AM, Andre Przywara <andre.przywara@arm.com> wrote:
> In many parts of the computing world having a unique MAC address
> sitting in some on-NIC storage is considered the normal case.
> Remove the warning to not scare the user unnecessarily.
> This applies to Highbank/Midway and ARM's Juno, for instance.
> Besides that this fixes the formatting on Midway, for instance,
> which currently looks like:
> ...
> Net: xgmac0
> Warning: xgmac0 using MAC address from net device
> , xgmac1
> Warning: xgmac1 using MAC address from net device
> ...
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> net/eth.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index 6cf3a35..a1b8abc 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -761,8 +761,6 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name,
> } else if (is_valid_ethaddr(dev->enetaddr)) {
> eth_setenv_enetaddr_by_index(base_name, eth_number,
> dev->enetaddr);
> - printf("\nWarning: %s using MAC address from net device\n",
> - dev->name);
Guess this only changes the legacy case. The DM case still warns.
-Joe
> } else if (is_zero_ethaddr(dev->enetaddr)) {
> #ifdef CONFIG_NET_RANDOM_ETHADDR
> net_random_ethaddr(dev->enetaddr);
> --
> 2.6.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-26 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-04 15:48 [U-Boot] [PATCH] net: remove scary warning about EEPROM provided MAC address Andre Przywara
2016-01-04 15:52 ` Tom Rini
2016-01-09 3:35 ` [U-Boot] " Tom Rini
2016-01-26 15:02 ` [U-Boot] [PATCH] " Joe Hershberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox