public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx6cuboxi: Fix the reset delay for the AR8035 PHY
Date: Mon, 4 Jan 2016 19:33:24 -0500	[thread overview]
Message-ID: <20160105003324.GG4093@bill-the-cat> (raw)
In-Reply-To: <1451950688-10549-1-git-send-email-festevam@gmail.com>

On Mon, Jan 04, 2016 at 09:38:08PM -0200, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Since commit 59370f3fcd1350 ("net: phy: delay only if reset handler is
> registered") Ethernet is no longer functional:
> 
> Booting from net ...                                                            
> FEC Waiting for PHY auto negotiation to complete......... TIMEOUT !             
> BOOTP broadcast 1                                                               
> BOOTP broadcast 2                                                               
> BOOTP broadcast 3                                                               
> BOOTP broadcast 4 
> 
> This commit does not have an issue in itself, but it revelead a problem
> with the Ethernet initialization.
> 
> As per the AR8035 datasheet:
> 
> "For a reliable power on reset, suggest to keep asserting the reset
> low long enough (10ms) to ensure the clock is stable and clock-to-reset
> 1ms requirement is satisfied."
> 
> So do as suggested and keep the reset low for 10ms.
> 
> Also add a 100us delay after deasserting the reset line
> to guarantee that the PHY ID can be read correctly and the Atheros 
> PHY can be loaded as per Troy Kisky's suggestion.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Repeated my test from V1, still passes (and takes a while for the
initial BOOTP reply):

Tested-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160104/586f6e7a/attachment.sig>

  reply	other threads:[~2016-01-05  0:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 23:38 [U-Boot] [PATCH v2] mx6cuboxi: Fix the reset delay for the AR8035 PHY Fabio Estevam
2016-01-05  0:33 ` Tom Rini [this message]
2016-01-07 19:41   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160105003324.GG4093@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox