From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Wed, 6 Jan 2016 09:39:48 +0800 Subject: [U-Boot] [PATCH 1/2] imx: mx6: add more entry for mxc_ccm_reg In-Reply-To: <568C09A5.70302@nelint.com> References: <1451887842-3747-1-git-send-email-peng.fan@nxp.com> <568C09A5.70302@nelint.com> Message-ID: <20160106013946.GA3634@linux-7smt.suse> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Eric, On Tue, Jan 05, 2016 at 11:21:25AM -0700, Eric Nelson wrote: >Hi Peng, > >On 01/03/2016 11:10 PM, Peng Fan wrote: >> Add more entries for structure mxc_ccm_reg. >> >> Signed-off-by: Peng Fan >> Cc: Stefano Babic >> --- >> arch/arm/include/asm/arch-mx6/crm_regs.h | 87 ++++++++++++++++++++++++++++++++ >> 1 file changed, 87 insertions(+) >> >> diff --git a/arch/arm/include/asm/arch-mx6/crm_regs.h b/arch/arm/include/asm/arch-mx6/crm_regs.h >> index 13e0a3d..787eb68 100644 >> --- a/arch/arm/include/asm/arch-mx6/crm_regs.h >> +++ b/arch/arm/include/asm/arch-mx6/crm_regs.h >> @@ -103,6 +103,93 @@ struct mxc_ccm_reg { >> u32 analog_pfd_528_set; >> u32 analog_pfd_528_clr; >> u32 analog_pfd_528_tog; > >I'd like to see some comments here about where in the reference manuals >these registers are defined, since they're not in the CCM section. Will add comments in V2. Thanks for comments. > >Also, I think these should be named to match the RM >i.e. pmu_reg_1p1 Yeah. > >> + u32 reg_1p1; >> + u32 reg_1p1_set; >> + u32 reg_1p1_clr; >> + u32 reg_1p1_tog; >> + u32 reg_3p0; >> + u32 reg_3p0_set; >> + u32 reg_3p0_clr; >> + u32 reg_3p0_tog; >> + u32 reg_2p5; >> + u32 reg_2p5_set; >> + u32 reg_2p5_clr; >> + u32 reg_2p5_tog; >> + u32 reg_core; >> + u32 reg_core_set; >> + u32 reg_core_clr; >> + u32 reg_core_tog; The upper are from pmu chapter. >> + u32 ana_misc0; >> + u32 ana_misc0_set; >> + u32 ana_misc0_clr; >> + u32 ana_misc0_tog; >> + u32 ana_misc1; >> + u32 ana_misc1_set; >> + u32 ana_misc1_clr; >> + u32 ana_misc1_tog; >> + u32 ana_misc2; >> + u32 ana_misc2_set; >> + u32 ana_misc2_clr; > >... pmu_misc2_tog > >> + u32 ana_misc2_tog; The upper registers are shared between CCM_ANALOG_MISCx and PMU_MISCx. > >TEMPMON registers > >> + u32 tempsense0; >> + u32 tempsense0_set; >> + u32 tempsense0_clr; >> + u32 tempsense0_tog; >> + u32 tempsense1; >> + u32 tempsense1_set; >> + u32 tempsense1_clr; >> + u32 tempsense1_tog; > >... and USB_ANALOG here >> + u32 usb1_vbus_detect; >> + u32 usb1_vbus_detect_set; >> + u32 usb1_vbus_detect_clr; >> + u32 usb1_vbus_detect_tog; >> + u32 usb1_chrg_detect; >> + u32 usb1_chrg_detect_set; >> + u32 usb1_chrg_detect_clr; >> + u32 usb1_chrg_detect_tog; >> + u32 usb1_vbus_det_stat; >> + u32 usb1_vbus_det_stat_set; >> + u32 usb1_vbus_det_stat_clr; >> + u32 usb1_vbus_det_stat_tog; >> + u32 usb1_chrg_det_stat; >> + u32 usb1_chrg_det_stat_set; >> + u32 usb1_chrg_det_stat_clr; >> + u32 usb1_chrg_det_stat_tog; >> + u32 usb1_loopback; >> + u32 usb1_loopback_set; >> + u32 usb1_loopback_clr; >> + u32 usb1_loopback_tog; >> + u32 usb1_misc; >> + u32 usb1_misc_set; >> + u32 usb1_misc_clr; >> + u32 usb1_misc_tog; >> + u32 usb2_vbus_detect; >> + u32 usb2_vbus_detect_set; >> + u32 usb2_vbus_detect_clr; >> + u32 usb2_vbus_detect_tog; >> + u32 usb2_chrg_detect; >> + u32 usb2_chrg_detect_set; >> + u32 usb2_chrg_detect_clr; >> + u32 usb2_chrg_detect_tog; >> + u32 usb2_vbus_det_stat; >> + u32 usb2_vbus_det_stat_set; >> + u32 usb2_vbus_det_stat_clr; >> + u32 usb2_vbus_det_stat_tog; >> + u32 usb2_chrg_det_stat; >> + u32 usb2_chrg_det_stat_set; >> + u32 usb2_chrg_det_stat_clr; >> + u32 usb2_chrg_det_stat_tog; >> + u32 usb2_loopback; >> + u32 usb2_loopback_set; >> + u32 usb2_loopback_clr; >> + u32 usb2_loopback_tog; >> + u32 usb2_misc; >> + u32 usb2_misc_set; >> + u32 usb2_misc_clr; >> + u32 usb2_misc_tog; >> + u32 digprog; >> + u32 reserved1[7]; >> + u32 digprog_sololite; >> }; >> #endif >> >> > >Otherwise, I checked these against the i.MX6DQ/SDL/SL and UL manuals >(not i.MX6SX), and i.MX6SX has same map. > >Reviewed-By: Eric Nelson Thanks, Peng. >