[U-Boot] [PATCH v1 09/16] ehci: Add support for Qualcomm EHCI

Marek Vasut
2016-01-11T22:02:32Z

On Monday, January 11, 2016 at 10:39:46 PM, Mateusz Kulikowski wrote:
> On 06.01.2016 22:04, Marek Vasut wrote:
> > On Wednesday, January 06, 2016 at 07:21:21 PM, Mateusz Kulikowski wrote:
> >> This driver is able to reconfigure OTG controller into HOST mode.
> >> Board can add board-specific initialization as board_prepare_usb().
> >> It requires USB_ULPI_VIEWPORT enabled in board configuration.
> >>
> >> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> >
> > [...]
> >
> >> +static int msm_init_after_reset(struct ehci_ctrl *dev)
> >> +{
> >> + struct msm_ehci_priv *p = container_of(dev, struct msm_ehci_priv,
> >> ctrl); + struct usb_ehci *ehci = p->ehci;
> >> +
> >> + /* select ULPI phy */
> >> + writel(0x80000000, &ehci->portsc);
> >
> > Don't we have macro for this bit ?
>
> hmhm.. I need spoiler..
>
> Did you meant EHCI_PS_* series of #defines from ehci.h?
>
> This bit is not there (header was probably based on EHCI 1.0 spec, where
> this bit was reserved). Of course I can add it there and use here :)

More like include/usb/ehci-fsl.h , there's a bit for it.

Best regards,
Marek Vasut