[U-Boot] [PATCH v1 05/16] usb: ulpi: Add Kconfig options for ULPI

Simon Glass
2016-01-07T23:18:46Z

Hi,

On 7 January 2016 at 15:12, Mateusz Kulikowski
<mateusz.kulikowski@gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 06.01.2016 21:49, Marek Vasut wrote:
>> On Wednesday, January 06, 2016 at 07:21:17 PM, Mateusz Kulikowski wrote:
>>> The following options can be now enabled via defconfig:
>>> - CONFIG_USB_ULPI
>>> - CONFIG_USB_ULPI_VIEWPORT
>>> - CONFIG_USB_ULPI_VIEWPORT_OMAP
>>>
> [...]
>
>>> +++ b/drivers/usb/ulpi/Kconfig
>>> @@ -0,0 +1,10 @@
>>> +comment "ULPI drivers"
>>> +
>>> +config USB_ULPI
>>> + bool
>>> +
>>> +config USB_ULPI_VIEWPORT
>>> + bool
>>> +
>>> +config USB_ULPI_VIEWPORT_OMAP
>>> + bool
>>
>> Description of these options is missing.
>
> My intention here was to keep it away from "users".
>
> This options are not "optional" in any way.
> They are rather like CPU_something or VBAR_something,
> that is - they are required and should be selected by drivers that use them,
> but without this drivers, they are useless.

Perhaps we don't need the options at all then?

But there are lots of users in the tree. You should use the
moveconfig.py script to move them all to Kconfig.

>
> But maybe I'm missing something :)
> If anyone insists on that - I'll make them visible and add description.

Please add detailed help for all Kconfig options you add.
>

Regards,
Simon