[U-Boot] [PATCH v1 16/16] board: Add Qualcomm Dragonboard 410C support

Simon Glass
2016-01-20T04:35:11Z

Hi Mateusz,

On 6 January 2016 at 11:21, Mateusz Kulikowski
<mateusz.kulikowski@gmail.com> wrote:
> This commit add support for 96Boards Dragonboard410C.
>
> It is board based on APQ8016 Qualcomm SoC, complying with
> 96boards specification.
>
> Features (present out of the box):
> - 4x Cortex A53 (ARMv8)
> - 2x USB Host port
> - 1x USB Device port
> - 4x LEDs
> - 1x HDMI connector
> - 1x uSD connector
> - 3x buttons (Power, Vol+, Vol-/Reset)
> - WIFI, Bluetooth with integrated antenna
> - 8GiB eMMC
>
> U-Boot boots chained with fastboot in 64-bit mode.
> For detailed build instructions see readme.txt in board directory.
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
>
> Changes in v1:
> - Add better help for dragonboard
> - Move static structures to board_prepare_usb
> - Add DM_SPMI to defconfig
>
> arch/arm/dts/Makefile | 2 +
> arch/arm/dts/dragonboard410c.dts | 154 +++++++++++++++++++
> arch/arm/mach-snapdragon/Kconfig | 20 +++
> board/qualcomm/dragonboard410c/Kconfig | 15 ++
> board/qualcomm/dragonboard410c/Makefile | 8 +
> board/qualcomm/dragonboard410c/dragonboard410c.c | 111 ++++++++++++++
> board/qualcomm/dragonboard410c/head.S | 20 +++
> board/qualcomm/dragonboard410c/readme.txt | 40 +++++
> board/qualcomm/dragonboard410c/u-boot.lds | 90 +++++++++++
> configs/dragonboard410c_defconfig | 30 ++++
> include/configs/dragonboard410c.h | 182 +++++++++++++++++++++++
> 11 files changed, 672 insertions(+)
> create mode 100644 arch/arm/dts/dragonboard410c.dts
> create mode 100644 board/qualcomm/dragonboard410c/Kconfig
> create mode 100644 board/qualcomm/dragonboard410c/Makefile
> create mode 100644 board/qualcomm/dragonboard410c/dragonboard410c.c
> create mode 100644 board/qualcomm/dragonboard410c/head.S
> create mode 100644 board/qualcomm/dragonboard410c/readme.txt
> create mode 100644 board/qualcomm/dragonboard410c/u-boot.lds
> create mode 100644 configs/dragonboard410c_defconfig
> create mode 100644 include/configs/dragonboard410c.h

Can you please add a MAINTAINERS file also?

Tested-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 0bcd316..47aecf5 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -95,6 +95,8 @@ dtb-$(CONFIG_FSL_LSCH3) += fsl-ls2080a-qds.dtb \
> dtb-$(CONFIG_FSL_LSCH2) += fsl-ls1043a-qds.dtb \
> fsl-ls1043a-rdb.dtb
>
> +dtb-$(CONFIG_ARCH_SNAPDRAGON) += dragonboard410c.dtb
> +
> dtb-$(CONFIG_MACH_SUN4I) += \
> sun4i-a10-a1000.dtb \
> sun4i-a10-ba10-tvbox.dtb \
> diff --git a/arch/arm/dts/dragonboard410c.dts b/arch/arm/dts/dragonboard410c.dts
> new file mode 100644
> index 0000000..1de5d23
> --- /dev/null
> +++ b/arch/arm/dts/dragonboard410c.dts
> @@ -0,0 +1,154 @@
> +/dts-v1/;
> +
> +#include "skeleton64.dtsi"
> +
> +/ {
> + model = "Qualcomm Technologies, Inc. Dragonboard 410c";
> + compatible = "qcom,dragonboard", "qcom,apq8016-sbc";
> + qcom,msm-id = <0xce 0x0 0xf8 0x0 0xf9 0x0 0xfa 0x0 0xf7 0x0>;
> + qcom,board-id = <0x10018 0x0>;
> + #address-cells = <0x2>;
> + #size-cells = <0x2>;
> +
> + memory {
> + device_type = "memory";
> + reg = <0 0x80000000 0 0x3da00000>;
> + };
> +
> + chosen {
> + stdout-path = "/soc/serial at 78b0000";
> + };
> +
> +
> + soc {
> + #address-cells = <0x1>;
> + #size-cells = <0x1>;
> + ranges = <0x0 0x0 0x0 0xffffffff>;
> + compatible = "simple-bus";
> +
> + clkc: qcom,gcc at 1800000 {
> + compatible = "qcom,gcc-apq8016";
> + reg = <0x1800000 0x80000>;
> + #address-cells = <0x1>;
> + #size-cells = <0x0>;
> + };
> +
> + serial at 78b0000 {
> + compatible = "qcom,msm-uartdm-v1.4";
> + reg = <0x78b0000 0x200>;
> + u-boot,dm-pre-reloc;
> + clock = <&clkc 4>;
> + };
> +
> + restart at 4ab000 {
> + compatible = "qcom,pshold";
> + reg = <0x4ab000 0x4>;
> + };
> +
> + soc_gpios: pinctrl at 1000000 {
> + compatible = "qcom,apq8016-pinctrl";
> + reg = <0x1000000 0x300000>;
> + gpio-controller;
> + gpio-count = <122>;
> + gpio-bank-name="soc";
> + #gpio-cells = <1>;
> + };
> +
> + ehci at 78d9000 {
> + compatible = "qcom,ehci-host";
> + reg = <0x78d9000 0x400>;
> + };
> +
> + sdhci at 07824000 {
> + compatible = "qcom,sdhci-msm-v4";
> + reg = <0x7824900 0x11c 0x7824000 0x800>;
> + bus-width = <0x8>;
> + index = <0x0>;
> + non-removable;
> + clock = <&clkc 0>;
> + clock-frequency = <100000000>;
> + };
> +
> + sdhci at 07864000 {
> + compatible = "qcom,sdhci-msm-v4";
> + reg = <0x7864900 0x11c 0x7864000 0x800>;
> + index = <0x1>;
> + bus-width = <0x4>;
> + clock = <&clkc 1>;
> + clock-frequency = <200000000>;
> + };
> +
> + spmi at 200f000 {
> + compatible = "qcom,spmi-pmic-arb";
> + reg = <0x200f800 0x200 0x2400000 0x400000 0x2c00000 0x400000>;
> + #address-cells = <0x1>;
> + #size-cells = <0x1>;
> + pm8916 at 0 {
> + compatible = "qcom,spmi-pmic";
> + reg = <0x0 0x1>;
> + #address-cells = <0x1>;
> + #size-cells = <0x1>;
> +
> + pmic_pon: pon at 800 {
> + compatible = "qcom,pm8916-pwrkey";
> + reg = <0x800 0x96>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + pmic_gpios: gpios at c000 {
> + compatible = "qcom,pm8916-gpio";
> + reg = <0xc000 0x400>;
> + gpio-controller;
> + gpio-count = <4>;
> + #gpio-cells = <2>;
> + gpio-bank-name="pmic";
> + };
> + };
> +
> + pm8916 at 1 {
> + compatible = "qcom,spmi-pmic";
> + reg = <0x1 0x1>;
> + };
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + user1 {
> + label = "green:user1";
> + gpios = <&soc_gpios 21 0>;
> + };
> +
> + user2 {
> + label = "green:user2";
> + gpios = <&soc_gpios 120 0>;
> + };
> +
> + user3 {
> + label = "green:user3";
> + gpios = <&pmic_gpios 0 0>;
> + };
> +
> + user4 {
> + label = "green:user4";
> + gpios = <&pmic_gpios 1 0>;
> + };
> + };
> +
> + usb_hub_reset_n_pm {
> + gpios = <&pmic_gpios 2 0>;
> + };
> +
> + usb_sw_sel_pm {
> + gpios = <&pmic_gpios 3 0>;
> + };
> +
> + key_vol_down {
> + gpios = <&pmic_pon 1 0>;
> + };
> +
> + key_power {
> + gpios = <&pmic_pon 0 0>;
> + };
> +};
> diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig
> index 156e733..dc7ba21 100644
> --- a/arch/arm/mach-snapdragon/Kconfig
> +++ b/arch/arm/mach-snapdragon/Kconfig
> @@ -3,4 +3,24 @@ if ARCH_SNAPDRAGON
> config SYS_SOC
> default "snapdragon"
>
> +choice
> + prompt "Snapdragon board select"
> +
> +config TARGET_DRAGONBOARD410C
> + bool "96Boards Dragonboard 410C"
> + help
> + Support for 96Boards Dragonboard 410C. This board complies with
> + 96Board Open Platform Specifications. Features:
> + - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306)
> + - 1GiB RAM
> + - 8GiB eMMC, uSD slot
> + - WiFi, Bluetooth and GPS module
> + - 2x Host, 1x Device USB port
> + - HDMI
> + - 20-pin low speed and 40-pin high speed expanders, 4 LED, 3 buttons
> +
> +endchoice
> +
> +source "board/qualcomm/dragonboard410c/Kconfig"
> +
> endif
> diff --git a/board/qualcomm/dragonboard410c/Kconfig b/board/qualcomm/dragonboard410c/Kconfig
> new file mode 100644
> index 0000000..03bd7ae
> --- /dev/null
> +++ b/board/qualcomm/dragonboard410c/Kconfig
> @@ -0,0 +1,15 @@
> +if TARGET_DRAGONBOARD410C
> +
> +config SYS_BOARD
> + default "dragonboard410c"
> +
> +config SYS_VENDOR
> + default "qualcomm"
> +
> +config SYS_SOC
> + default "apq8016"
> +
> +config SYS_CONFIG_NAME
> + default "dragonboard410c"
> +
> +endif
> diff --git a/board/qualcomm/dragonboard410c/Makefile b/board/qualcomm/dragonboard410c/Makefile
> new file mode 100644
> index 0000000..cd67808
> --- /dev/null
> +++ b/board/qualcomm/dragonboard410c/Makefile
> @@ -0,0 +1,8 @@
> +#
> +# (C) Copyright 2015 Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> +#
> +# SPDX-License-Identifier: GPL-2.0+
> +#
> +
> +obj-y := dragonboard410c.o
> +extra-y += head.o
> diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard410c.c
> new file mode 100644
> index 0000000..5ca9659
> --- /dev/null
> +++ b/board/qualcomm/dragonboard410c/dragonboard410c.c
> @@ -0,0 +1,111 @@
> +/*
> + * Board init file for Dragonboard 410C
> + *
> + * (C) Copyright 2015 Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> +
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <dm.h>
> +#include <usb.h>
> +#include <asm/gpio.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +int dram_init(void)
> +{
> + gd->ram_size = PHYS_SDRAM_1_SIZE;
> + return 0;
> +}
> +
> +void dram_init_banksize(void)
> +{
> + gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> + gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> +}
> +
> +
> +int board_prepare_usb(enum usb_init_type type)
> +{
> + static struct gpio_desc hub_reset, usb_sel;
> + int ret = 0, node;
> +
> + /* Try to request gpios needed to start usb host on dragonboard */
> + if (!dm_gpio_is_valid(&hub_reset)) {
> + node = fdt_subnode_offset(gd->fdt_blob, 0,
> + "usb_hub_reset_n_pm");
> + if (node < 0) {
> + printf("Failed to find usb_hub_reset_n_pm dt node.\n");
> + return node;
> + }
> + ret = gpio_request_by_name_nodev(gd->fdt_blob, node, "gpios", 0,
> + &hub_reset, 0);
> + if (ret < 0) {
> + printf("Failed to request usb_hub_reset_n_pm gpio.\n");
> + return ret;
> + }
> + }
> +
> + if (!dm_gpio_is_valid(&usb_sel)) {
> + node = fdt_subnode_offset(gd->fdt_blob, 0, "usb_sw_sel_pm");
> + if (node < 0) {
> + printf("Failed to find usb_sw_sel_pm dt node.\n");
> + return 0;
> + }
> + ret = gpio_request_by_name_nodev(gd->fdt_blob, node, "gpios", 0,
> + &usb_sel, 0);
> + if (ret < 0) {
> + printf("Failed to request usb_sw_sel_pm gpio.\n");
> + return ret;
> + }
> + }
> +
> + if (type == USB_INIT_HOST) {
> + /* Start USB Hub */
> + dm_gpio_set_dir_flags(&hub_reset,
> + GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
> + mdelay(100);
> + /* Switch usb to host connectors */
> + dm_gpio_set_dir_flags(&usb_sel,
> + GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
> + mdelay(100);
> + } else { /* Device */
> + /* Disable hub */
> + dm_gpio_set_dir_flags(&hub_reset, GPIOD_IS_OUT);
> + /* Switch back to device connector */
> + dm_gpio_set_dir_flags(&usb_sel, GPIOD_IS_OUT);
> + }
> + return 0;
> +}
> +
> +int board_init(void)
> +{
> + return 0;
> +}
> +
> +/* Check for vol- button - if pressed - stop autoboot */
> +int misc_init_r(void)
> +{
> + int node;
> + struct gpio_desc resin;
> +
> + node = fdt_subnode_offset(gd->fdt_blob, 0, "key_vol_down");
> + if (node < 0) {
> + printf("Failed to find key_vol_down node. Check device tree\n");
> + return 0;
> + }
> +
> + if (gpio_request_by_name_nodev(gd->fdt_blob, node, "gpios", 0, &resin,
> + 0)) {
> + printf("Failed to request key_vol_down button.\n");
> + return 0;
> + }
> +
> + if (dm_gpio_get_value(&resin)) {
> + setenv("bootdelay", "-1");
> + printf("Power button pressed - dropping to console.\n");
> + }
> +
> + return 0;
> +}
> diff --git a/board/qualcomm/dragonboard410c/head.S b/board/qualcomm/dragonboard410c/head.S
> new file mode 100644
> index 0000000..00d6d97
> --- /dev/null
> +++ b/board/qualcomm/dragonboard410c/head.S
> @@ -0,0 +1,20 @@
> +#include <config.h>
> +
> +.global _fastboot_header
> +_fastboot_header:
> + b _start
> + add x13, x18, #0x16
> + // Image load offset from start of RAM, little-endian
> + .quad CONFIG_SYS_TEXT_BASE-PHYS_SDRAM_1
> + // Effective size of kernel image, little-endian
> + .quad 0 //0x60000
> + // Informative flags, little-endian
> + .quad 0
> + .quad 0 // reserved
> + .quad 0 // reserved
> + .quad 0 // reserved
> + .byte 0x41 // Magic number, "ARM\x64"
> + .byte 0x52
> + .byte 0x4d
> + .byte 0x64
> + .word 0 // reserved
> diff --git a/board/qualcomm/dragonboard410c/readme.txt b/board/qualcomm/dragonboard410c/readme.txt
> new file mode 100644
> index 0000000..0f575db
> --- /dev/null
> +++ b/board/qualcomm/dragonboard410c/readme.txt
> @@ -0,0 +1,40 @@
> +#
> +# (C) Copyright 2015 Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> +#
> +# SPDX-License-Identifier: GPL-2.0+
> +#
> +
> +Build & Run instructions:
> +
> +1) Install mkbootimg from git://codeaurora.org/quic/kernel/skales (15ece94f09 worked for me)
> +2) Setup CROSS_COMPILE to aarch64 compiler
> +3) make dragonboard410c_config
> +4) make
> +5) generate fake, empty ramdisk (can have 0 bytes)
> +$ touch rd
> +
> +6) generate qualcomm device tree, use dtbTool to generate it
> +$ dtbTool -o dt.img arch/arm/dts

What is this file?

> +
> +7) generate image with mkbootimg:
> +$ mkbootimg --kernel=u-boot-dtb.bin --output=u-boot.img --dt=dt.img --pagesize 2048 --base 0x80000000 --ramdisk=rd --cmdline=""

Is it possible to add this functionality to mkimage? Is this building
a fastboot image?

> +
> +Boot it with fastboot:
> +fastboot boot u-boot.img
> +or flash as kernel:
> +fastboot flash boot u-boot.img
> +fastboot reboot
> +
> +
> +What is working:
> +- UART
> +- GPIO (SoC)
> +- SD
> +- eMMC
> +- Reset
> +- USB in EHCI mode (usb starts does switch device->host, usb stop does the opposite)
> +- PMIC GPIOS (but not in generic subsystem)
> +- PMIC "special" buttons (power, vol-)
> +
> +What is not working / known bugs:
> +- SDHCI is slow (~2.5MiB/s for SD and eMMC)

[snip]

Regards,
Simon