From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 7 Jan 2016 03:21:40 +0100 Subject: [U-Boot] [PATCH] arm: socfpga: set the fpga global bit to disable HPS to FPGA signals In-Reply-To: <1452109723-17059-1-git-send-email-dinguyen@opensource.altera.com> References: <1452109723-17059-1-git-send-email-dinguyen@opensource.altera.com> Message-ID: <201601070321.40398.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, January 06, 2016 at 08:48:43 PM, dinguyen at opensource.altera.com wrote: > From: Dinh Nguyen > > We should be setting the FPGA Interface Group global bit that will > correctly disable all interfaces between the FPGA and HPS. > > Signed-off-by: Dinh Nguyen > --- > drivers/fpga/socfpga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c > index 4448250..431e159 100644 > --- a/drivers/fpga/socfpga.c > +++ b/drivers/fpga/socfpga.c > @@ -269,7 +269,7 @@ int socfpga_load(Altera_desc *desc, const void > *rbf_data, size_t rbf_size) /* Prior programming the FPGA, all bridges > need to be shut off */ > > /* Disable all signals from hps peripheral controller to fpga */ > - writel(0, &sysmgr_regs->fpgaintfgrp_module); > + writel(0, &sysmgr_regs->fpgaintfgrp_gbl); > > /* Disable all signals from FPGA to HPS SDRAM */ > #define SDR_CTRLGRP_FPGAPORTRST_ADDRESS 0x5080 Looks fine, Acked-by: Marek Vasut btw Shouldn't you also fix the same thing in drivers/fpga/socfpga.c ? Even better, can't we have a single function to enable/disable the interfaces? Best regards, Marek Vasut