[U-Boot] [PATCH] arm: socfpga: set the fpga global bit to disable HPS to FPGA signals

Dinh Nguyen
2016-01-07T02:50:00Z

On 01/06/2016 08:21 PM, Marek Vasut wrote:
> On Wednesday, January 06, 2016 at 08:48:43 PM, dinguyen at opensource.altera.com
> wrote:
>> From: Dinh Nguyen <dinh.linux@gmail.com>
>>
>> We should be setting the FPGA Interface Group global bit that will
>> correctly disable all interfaces between the FPGA and HPS.
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
>> ---
>> drivers/fpga/socfpga.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c
>> index 4448250..431e159 100644
>> --- a/drivers/fpga/socfpga.c
>> +++ b/drivers/fpga/socfpga.c
>> @@ -269,7 +269,7 @@ int socfpga_load(Altera_desc *desc, const void
>> *rbf_data, size_t rbf_size) /* Prior programming the FPGA, all bridges
>> need to be shut off */
>>
>> /* Disable all signals from hps peripheral controller to fpga */
>> - writel(0, &sysmgr_regs->fpgaintfgrp_module);
>> + writel(0, &sysmgr_regs->fpgaintfgrp_gbl);
>>
>> /* Disable all signals from FPGA to HPS SDRAM */
>> #define SDR_CTRLGRP_FPGAPORTRST_ADDRESS 0x5080
>
> Looks fine,
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> btw Shouldn't you also fix the same thing in drivers/fpga/socfpga.c ? Even

I'm confused by what you mean here. The patch is for drivers/fpga/socfpga.c.

> better, can't we have a single function to enable/disable the interfaces?
>

We probably could, but I don't see a need for other functions to
enable/disable the interfaces.

Dinh