From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel
Date: Thu, 7 Jan 2016 11:28:30 -0500 [thread overview]
Message-ID: <20160107162830.GC3359@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5ChruMj=abNAUs3Jm2Mge3xZTfTmEXWOh6QBKS3p1wJFQ@mail.gmail.com>
On Thu, Jan 07, 2016 at 11:31:06AM -0200, Fabio Estevam wrote:
> On Thu, Jan 7, 2016 at 10:58 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> > Ah, yes! Sorry I wanted to say the original proposal to "return 0"
> > instead. But now I failed to understand why this fixed the issue
> > because those error numbers are not zero.
>
> The problem only happens if we return a negative value.
>
> > And why returning zero is bad? From a working PCIe controller (either
>
> It is not bad, but I still prefer to keep in sync with the kernel driver.
And would allow further features later on?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160107/51ef1fb5/attachment.sig>
next prev parent reply other threads:[~2016-01-07 16:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 20:53 [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel Fabio Estevam
2016-01-06 20:53 ` [U-Boot] [PATCH 2/3] pcie_imx: Adjust the return value when imx_pcie_addr_valid() fails Fabio Estevam
2016-01-06 20:57 ` Marek Vasut
2016-01-06 20:53 ` [U-Boot] [PATCH 3/3] pcie_layerscape: Adjust the return value when ls_pcie_addr_valid() fails Fabio Estevam
2016-01-06 20:58 ` Marek Vasut
2016-01-06 20:57 ` [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel Marek Vasut
2016-01-06 22:55 ` Tom Rini
2016-01-06 22:58 ` Fabio Estevam
2016-01-06 23:10 ` Tom Rini
2016-01-07 2:11 ` Bin Meng
2016-01-07 12:15 ` Fabio Estevam
2016-01-07 12:58 ` Bin Meng
2016-01-07 13:31 ` Fabio Estevam
2016-01-07 16:28 ` Tom Rini [this message]
2016-01-07 16:49 ` Fabio Estevam
2016-01-08 0:02 ` Bin Meng
2016-01-08 0:15 ` Fabio Estevam
2016-01-08 0:31 ` Bin Meng
2016-01-08 0:35 ` Marek Vasut
2016-01-08 1:10 ` Bin Meng
2016-01-08 0:46 ` Bin Meng
2016-01-08 0:48 ` Bin Meng
2016-01-08 2:09 ` Fabio Estevam
2016-01-08 2:18 ` Bin Meng
2016-01-08 2:20 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107162830.GC3359@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox