From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: Define USB_MAX_STOR_DEV in only one place
Date: Fri, 8 Jan 2016 13:04:15 +0100 [thread overview]
Message-ID: <201601081304.15515.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ3MTesvoSWkzuP+7TSkf2Ag2pKFXxuBrG66uAiOc0Vryw@mail.gmail.com>
On Friday, January 08, 2016 at 04:34:44 AM, Simon Glass wrote:
> Hi Marek,
>
> On 7 January 2016 at 15:50, Marek Vasut <marex@denx.de> wrote:
> > On Thursday, January 07, 2016 at 11:16:08 PM, Simon Glass wrote:
> >> We can define this in the header file and use it in usb_storage.c. There
> >> is no need to define it twice. Remove the #define from usb_storage.c.
> >>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > I guess you build tested this properly, right ?
>
> Yes. I was initially nervous that there might be a reason for the two
> definitions but I cannot see what it might be. So I think this patch
> is safe. Anyway I'll hold off applying it until early in the merge
> window.
That's a good idea indeed. Thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-01-08 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 22:16 [U-Boot] [PATCH] usb: Define USB_MAX_STOR_DEV in only one place Simon Glass
2016-01-07 22:50 ` Marek Vasut
2016-01-08 3:34 ` Simon Glass
2016-01-08 12:04 ` Marek Vasut [this message]
2016-01-16 1:26 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601081304.15515.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox