From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 8 Jan 2016 13:04:15 +0100 Subject: [U-Boot] [PATCH] usb: Define USB_MAX_STOR_DEV in only one place In-Reply-To: References: <1452204968-9420-1-git-send-email-sjg@chromium.org> <201601072350.42323.marex@denx.de> Message-ID: <201601081304.15515.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, January 08, 2016 at 04:34:44 AM, Simon Glass wrote: > Hi Marek, > > On 7 January 2016 at 15:50, Marek Vasut wrote: > > On Thursday, January 07, 2016 at 11:16:08 PM, Simon Glass wrote: > >> We can define this in the header file and use it in usb_storage.c. There > >> is no need to define it twice. Remove the #define from usb_storage.c. > >> > >> Signed-off-by: Simon Glass > > > > I guess you build tested this properly, right ? > > Yes. I was initially nervous that there might be a reason for the two > definitions but I cannot see what it might be. So I think this patch > is safe. Anyway I'll hold off applying it until early in the merge > window. That's a good idea indeed. Thanks! Best regards, Marek Vasut