From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] usb: dwc2: does not compile in 2016-rc3 when updating from -rc1.
Date: Sun, 10 Jan 2016 14:45:54 +0100 [thread overview]
Message-ID: <201601101445.54821.marex@denx.de> (raw)
In-Reply-To: <20160110120417.GB7924@amd>
On Sunday, January 10, 2016 at 01:04:17 PM, Pavel Machek wrote:
> On Sun 2016-01-10 12:56:15, Pavel Machek wrote:
> > Hi!
> >
> > After updating from 2016-rc1, I get this compile error:
> > CC common/main.o
> > drivers/usb/host/dwc2.c: In function 'usb_lowlevel_init':
> > drivers/usb/host/dwc2.c:1028:40: error: 'CONFIG_USB_DWC2_REG_ADDR'
> > undeclared (first use in this function)
> >
> > priv->regs = (struct dwc2_core_regs *)CONFIG_USB_DWC2_REG_ADDR;
> >
> > ^
> >
> > make mrproper socfpga_cyclone5_config
> >
> > Fixes the problem.
>
> Well, it "fixes" the problem by not compiling dwc2.
>
> Socfpga clearly wants DWC2:
>
> include/configs/socfpga_common.h:#define CONFIG_USB_DWC2
> include/configs/socfpga_common.h:#define CONFIG_USB_GADGET_DWC2_OTG
>
> But does not contain required address:
>
> [pavel at pollux u-boot]$ grep -ri USB_DWC2_REG_ADDR .
> ./drivers/usb/host/dwc2.c: priv->regs = (struct dwc2_core_regs
> *)CONFIG_USB_DWC2_REG_ADDR; ./README: CONFIG_USB_DWC2_REG_ADDR
the
> physical CPU address of the DWC2 ./include/configs/hikey.h:#define
> CONFIG_USB_DWC2_REG_ADDR 0xF72C0000 ./include/configs/rpi-common.h:#define
> CONFIG_USB_DWC2_REG_ADDR 0x3f980000 ./include/configs/rpi-common.h:#define
> CONFIG_USB_DWC2_REG_ADDR 0x20980000
>
> Plus, make socfpga_cyclone5_config does not enable USB, which is
> probably error.
SoCFPGA is using USB DM , so these base addresses are pulled from OF
and are no longer hard-coded.
Pristine u-boot 2016.01-rc4 compiles fine for CV SoCDK. Can you please
test mainline _before_ reporting issues ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-01-10 13:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 5:00 [U-Boot] [PATCH] usb: dwc2: Enhance interrupt handling for CONTROL transaction Chin Liang See
2016-01-05 14:36 ` Marek Vasut
2016-01-05 15:51 ` Chin Liang See
2016-01-05 16:16 ` Marek Vasut
2016-01-13 2:58 ` Marek Vasut
2016-01-13 15:18 ` Chin Liang See
2016-01-13 15:22 ` Marek Vasut
2016-01-14 14:50 ` Chin Liang See
2016-01-14 15:20 ` Marek Vasut
2016-02-04 11:42 ` Marek Vasut
2016-02-19 9:11 ` Chin Liang See
2016-02-19 15:16 ` Marek Vasut
2016-01-10 11:56 ` [U-Boot] usb: dwc2: does not compile in 2016-rc3 when updating from -rc1 Pavel Machek
2016-01-10 12:04 ` Pavel Machek
2016-01-10 13:45 ` Marek Vasut [this message]
2016-01-10 17:50 ` Pavel Machek
2016-01-10 18:13 ` Marek Vasut
2016-01-10 18:39 ` [U-Boot] Are non-default configurations expected to work? " Pavel Machek
2016-01-10 18:42 ` Marek Vasut
2016-01-10 19:04 ` Tom Rini
2016-01-10 19:06 ` Marek Vasut
2016-01-10 19:16 ` Tom Rini
2016-01-10 19:18 ` Marek Vasut
2016-01-10 19:28 ` Tom Rini
2016-01-10 19:40 ` Marek Vasut
2016-01-10 20:11 ` Tom Rini
2016-01-10 20:18 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601101445.54821.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox