From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 10 Jan 2016 14:45:54 +0100
Subject: [U-Boot] usb: dwc2: does not compile in 2016-rc3 when updating
	from -rc1.
In-Reply-To: <20160110120417.GB7924@amd>
References: <1451970004-2344-1-git-send-email-clsee@altera.com>
 <20160110115615.GA7924@amd> <20160110120417.GB7924@amd>
Message-ID: <201601101445.54821.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sunday, January 10, 2016 at 01:04:17 PM, Pavel Machek wrote:
> On Sun 2016-01-10 12:56:15, Pavel Machek wrote:
> > Hi!
> > 
> > After updating from 2016-rc1, I get this compile error:
> >   CC      common/main.o
> >   drivers/usb/host/dwc2.c: In function 'usb_lowlevel_init':
> >   drivers/usb/host/dwc2.c:1028:40: error: 'CONFIG_USB_DWC2_REG_ADDR'
> >   undeclared (first use in this function)
> >   
> >     priv->regs = (struct dwc2_core_regs *)CONFIG_USB_DWC2_REG_ADDR;
> >     
> >                                             ^
> > 
> > make mrproper socfpga_cyclone5_config
> > 
> > Fixes the problem.
> 
> Well, it "fixes" the problem by not compiling dwc2.
> 
> Socfpga clearly wants DWC2:
> 
> include/configs/socfpga_common.h:#define CONFIG_USB_DWC2
> include/configs/socfpga_common.h:#define CONFIG_USB_GADGET_DWC2_OTG
> 
> But does not contain required address:
> 
> [pavel at pollux u-boot]$ grep -ri USB_DWC2_REG_ADDR .
> ./drivers/usb/host/dwc2.c:  priv->regs = (struct dwc2_core_regs
> *)CONFIG_USB_DWC2_REG_ADDR; ./README:		CONFIG_USB_DWC2_REG_ADDR 
the
> physical CPU address of the DWC2 ./include/configs/hikey.h:#define
> CONFIG_USB_DWC2_REG_ADDR 0xF72C0000 ./include/configs/rpi-common.h:#define
> CONFIG_USB_DWC2_REG_ADDR 0x3f980000 ./include/configs/rpi-common.h:#define
> CONFIG_USB_DWC2_REG_ADDR 0x20980000
> 
> Plus, make socfpga_cyclone5_config does not enable USB, which is
> probably error.

SoCFPGA is using USB DM , so these base addresses are pulled from OF
and are no longer hard-coded.

Pristine u-boot 2016.01-rc4 compiles fine for CV SoCDK. Can you please
test mainline _before_ reporting issues ?

Best regards,
Marek Vasut