From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 11 Jan 2016 23:02:32 +0100 Subject: [U-Boot] [PATCH v1 09/16] ehci: Add support for Qualcomm EHCI In-Reply-To: <56942122.5050004@gmail.com> References: <1452104488-5502-1-git-send-email-mateusz.kulikowski@gmail.com> <201601062204.07374.marex@denx.de> <56942122.5050004@gmail.com> Message-ID: <201601112302.32697.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, January 11, 2016 at 10:39:46 PM, Mateusz Kulikowski wrote: > On 06.01.2016 22:04, Marek Vasut wrote: > > On Wednesday, January 06, 2016 at 07:21:21 PM, Mateusz Kulikowski wrote: > >> This driver is able to reconfigure OTG controller into HOST mode. > >> Board can add board-specific initialization as board_prepare_usb(). > >> It requires USB_ULPI_VIEWPORT enabled in board configuration. > >> > >> Signed-off-by: Mateusz Kulikowski > > > > [...] > > > >> +static int msm_init_after_reset(struct ehci_ctrl *dev) > >> +{ > >> + struct msm_ehci_priv *p = container_of(dev, struct msm_ehci_priv, > >> ctrl); + struct usb_ehci *ehci = p->ehci; > >> + > >> + /* select ULPI phy */ > >> + writel(0x80000000, &ehci->portsc); > > > > Don't we have macro for this bit ? > > hmhm.. I need spoiler.. > > Did you meant EHCI_PS_* series of #defines from ehci.h? > > This bit is not there (header was probably based on EHCI 1.0 spec, where > this bit was reserved). Of course I can add it there and use here :) More like include/usb/ehci-fsl.h , there's a bit for it. Best regards, Marek Vasut