[U-Boot] [PATCH v3] socfpga: Modify qts-filter args to allow input for bsp generated files and quartus project directories

Chin Liang See
2016-01-12T00:26:58Z

On Mon, 2016-01-11 at 15:33 -0800, Dalon Westergreen wrote:
> The hps_isw_handoff and bsp/generated folders are typically not in
> the same path. This patch adds support for specifying the different
> input directories for the bsp and quartus projects.
>
> Signed-off-by: Dalon Westergreen <dwesterg@gmail.com>
> Acked-by: Marek Vasut <marex@denx.de>
> ---
> Changes for v2:
> - Add commit message
> Changes for v3:
> - Fix line length issues
> ---
> arch/arm/mach-socfpga/qts-filter.sh | 74 +++++++++++++++++++++------
> ----------
> 1 file changed, 43 insertions(+), 31 deletions(-)
>

Looks good to me with minor nickpicking on the help message.

Acked-by: Chin Liang See <clsee@altera.com>

Thanks
Chin Liang

> diff --git a/arch/arm/mach-socfpga/qts-filter.sh b/arch/arm/mach
> -socfpga/qts-filter.sh
> index c1640bc..b81a4e1 100755
> --- a/arch/arm/mach-socfpga/qts-filter.sh
> +++ b/arch/arm/mach-socfpga/qts-filter.sh
>

[..]

> @@ -176,30 +184,34 @@ EOF
> }
>
> usage() {
> - echo "$0 [soc_type] [input_dir] [output_dir]"
> + echo "$0 [soc_type] [input_qts_dir] [input_bsp_dir]
> [output_dir]"
> echo "Process QTS-generated headers into U-Boot compatible
> ones."
> echo ""
> - echo " soc_type\t\tType of SoC, either 'cyclone5' or
> 'arria5',"
> - echo " input_dir\t\tDirectory with the QTS project."
> - echo " output_dir\t\tDirectory to store the U-Boot
> compatible headers."
> + echo " soc_type - Type of SoC, either 'cyclone5' or
> 'arria5',"
> + echo " input_qts_dir - Directory with compiled Quartus
> project."

We can put Directory where the Quartus project file is located.

> + echo " input_bsp_dir - Directory with generated output
> from"
> + echo " the bsp-editor."

We can put Directory where the bsp-editor file settings.bsp is located.

> + echo " output_dir - Directory to store the U-Boot
> compatible headers."
> echo ""
> }
>
> soc="$1"
> -in_dir="$2"
> -out_dir="$3"
> +in_qts_dir="$2"
> +in_bsp_dir="$3"
> +out_dir="$4"
>
> -if [ "$#" -ne 3 ] ; then
> +if [ "$#" -ne 4 ] ; then
> usage
> exit 1
> fi
>
> -if [ ! -d "${in_dir}" -o ! -d "${out_dir}" -o -z "${soc}" ] ; then
> +if [ ! -d "${in_qts_dir}" -o ! -d "${in_bsp_dir}" -o \
> + ! -d "${out_dir}" -o -z "${soc}" ] ; then
> usage
> exit 3
> fi
>
> -process_iocsr_config "${soc}" "${in_dir}" "${out_dir}"
> -process_pinmux_config "${soc}" "${in_dir}" "${out_dir}"
> -process_pll_config "${soc}" "${in_dir}" "${out_dir}"
> -process_sdram_config "${soc}" "${in_dir}" "${out_dir}"
> +process_iocsr_config "${soc}" "${in_qts_dir}" "${in_bsp_dir}"
> "${out_dir}"
> +process_pinmux_config "${soc}" "${in_qts_dir}" "${in_bsp_dir}"
> "${out_dir}"
> +process_pll_config "${soc}" "${in_qts_dir}" "${in_bsp_dir}"
> "${out_dir}"
> +process_sdram_config "${soc}" "${in_qts_dir}" "${in_bsp_dir}"
> "${out_dir}"