[U-Boot] [PATCH v3] socfpga: Modify qts-filter args to allow input for bsp generated files and quartus project directories

Marek Vasut
2016-01-12T00:31:02Z

On Tuesday, January 12, 2016 at 01:26:58 AM, Chin Liang See wrote:
> On Mon, 2016-01-11 at 15:33 -0800, Dalon Westergreen wrote:
> > The hps_isw_handoff and bsp/generated folders are typically not in
> > the same path. This patch adds support for specifying the different
> > input directories for the bsp and quartus projects.
> >
> > Signed-off-by: Dalon Westergreen <dwesterg@gmail.com>
> > Acked-by: Marek Vasut <marex@denx.de>
> > ---
> >
> > Changes for v2:
> > - Add commit message
> >
> > Changes for v3:
> > - Fix line length issues
> >
> > ---
> >
> > arch/arm/mach-socfpga/qts-filter.sh | 74 +++++++++++++++++++++------
> >
> > ----------
> >
> > 1 file changed, 43 insertions(+), 31 deletions(-)
>
> Looks good to me with minor nickpicking on the help message.
>
> Acked-by: Chin Liang See <clsee@altera.com>
>
> Thanks
> Chin Liang
>
> > diff --git a/arch/arm/mach-socfpga/qts-filter.sh b/arch/arm/mach
> > -socfpga/qts-filter.sh
> > index c1640bc..b81a4e1 100755
> > --- a/arch/arm/mach-socfpga/qts-filter.sh
> > +++ b/arch/arm/mach-socfpga/qts-filter.sh
>
> [..]
>
> > @@ -176,30 +184,34 @@ EOF
> >
> > }
> >
> > usage() {
> >
> > - echo "$0 [soc_type] [input_dir] [output_dir]"
> > + echo "$0 [soc_type] [input_qts_dir] [input_bsp_dir]
> > [output_dir]"
> >
> > echo "Process QTS-generated headers into U-Boot compatible
> >
> > ones."
> >
> > echo ""
> >
> > - echo " soc_type\t\tType of SoC, either 'cyclone5' or
> > 'arria5',"
> > - echo " input_dir\t\tDirectory with the QTS project."
> > - echo " output_dir\t\tDirectory to store the U-Boot
> > compatible headers."
> > + echo " soc_type - Type of SoC, either 'cyclone5' or
> > 'arria5',"
> > + echo " input_qts_dir - Directory with compiled Quartus
> > project."
>
> We can put Directory where the Quartus project file is located.

Make sure to retain the "compiled" bit there, it's important as you cannot
extract these information from not-compiled quartus project.

> > + echo " input_bsp_dir - Directory with generated output
> > from"
> > + echo " the bsp-editor."
>
> We can put Directory where the bsp-editor file settings.bsp is located.

[...]

btw. Completely off-topic, but is there any chance altera will release the
algorithm to compute these magic values which are in the header files from
the base values inserted into the HPS component in QSys ? I think we might
just put these values into OF and do the computation in U-Boot on-the-fly.
This would also remove the need for this script.