public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: dwc2: Enhance interrupt handling for CONTROL transaction
Date: Wed, 13 Jan 2016 03:58:30 +0100	[thread overview]
Message-ID: <201601130358.31123.marex@denx.de> (raw)
In-Reply-To: <201601051716.05794.marex@denx.de>

On Tuesday, January 05, 2016 at 05:16:05 PM, Marek Vasut wrote:
> On Tuesday, January 05, 2016 at 04:51:47 PM, Chin Liang See wrote:
> > On Tue, 2016-01-05 at 15:36 +0100, Marek Vasut wrote:
> > > On Tuesday, January 05, 2016 at 06:00:04 AM, Chin Liang See wrote:
> > > > Per DesignWare USB OTG databook, driver should retry up to
> > > > 3 times when transaction error (hcint.xacterr) happen. But
> > > > the 3 times doesn't count when the response is nack
> > > > (hcint.nak) or frame overrun (hcint.frmoverun)
> > > > 
> > > > This patch solved the enumeration error as spotted at socfpga
> > > > cyclone5_socdk when plugging in certain pendrive.
> > > > 
> > > > Signed-off-by: Chin Liang See <clsee@altera.com>
> > > > Cc: Marek Vasut <marex@denx.de>
> > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > > > Cc: Pavel Machek <pavel@denx.de>
> > > > Cc: Oleksandr Tymoshenko <gonzo@bluezbox.com>
> > > > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > > > Cc: Alexander Stein <alexanders83@web.de>
> > > > Cc: Peter Griffin <peter.griffin@linaro.org>
> > > 
> > > I applied this change on top of u-boot-socfpga/master and tested it
> > > on
> > > SoCFPGA CycloneV SoCDK with "Sandisk cruzer force" stick. The board
> > > gets
> > > completely stuck if I have dcache ENABLED and perform 'usb reset'.
> > > This
> > 
> > > patch is:
> > Thanks Marek for testing. I managed to find a SanDisk Cruzer Blade and
> > notice the same fail behaviours as yours. FYI, note that this patch
> > works well with other 3 pendrive that I have.
> > 
> > With SanDisk, the dwc2 driver was timed out as hcint.xfercomp and
> > chhltd never get set even after 1s. It keep retrying endlessly due to
> > miss handling for the ETIMEDOUT within this patch.
> > 
> > In short, the retry doesn't work for SanDisk but the dcache disable
> > works. Need to figure out more what cause the failure.
> 
> Excellent, I have one of those too (I bought the entire lineup of these
> sandisk sticks at one point ;-) )

Hi, any news on the SoCFPGA USB/QSPI problem investigation? Thanks!

Best regards,
Marek Vasut

  reply	other threads:[~2016-01-13  2:58 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05  5:00 [U-Boot] [PATCH] usb: dwc2: Enhance interrupt handling for CONTROL transaction Chin Liang See
2016-01-05 14:36 ` Marek Vasut
2016-01-05 15:51   ` Chin Liang See
2016-01-05 16:16     ` Marek Vasut
2016-01-13  2:58       ` Marek Vasut [this message]
2016-01-13 15:18         ` Chin Liang See
2016-01-13 15:22           ` Marek Vasut
2016-01-14 14:50             ` Chin Liang See
2016-01-14 15:20               ` Marek Vasut
2016-02-04 11:42                 ` Marek Vasut
2016-02-19  9:11                   ` Chin Liang See
2016-02-19 15:16                     ` Marek Vasut
2016-01-10 11:56 ` [U-Boot] usb: dwc2: does not compile in 2016-rc3 when updating from -rc1 Pavel Machek
2016-01-10 12:04   ` Pavel Machek
2016-01-10 13:45     ` Marek Vasut
2016-01-10 17:50       ` Pavel Machek
2016-01-10 18:13         ` Marek Vasut
2016-01-10 18:39           ` [U-Boot] Are non-default configurations expected to work? " Pavel Machek
2016-01-10 18:42             ` Marek Vasut
2016-01-10 19:04             ` Tom Rini
2016-01-10 19:06               ` Marek Vasut
2016-01-10 19:16                 ` Tom Rini
2016-01-10 19:18                   ` Marek Vasut
2016-01-10 19:28                     ` Tom Rini
2016-01-10 19:40                       ` Marek Vasut
2016-01-10 20:11                         ` Tom Rini
2016-01-10 20:18                           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201601130358.31123.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox