From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: mx6/7 define CONFIG_SYS_VSNPRINTF
Date: Thu, 14 Jan 2016 09:54:09 +0800 [thread overview]
Message-ID: <20160114015407.GA2304@linux-7smt.suse> (raw)
In-Reply-To: <20160113195700.GJ3359@bill-the-cat>
Hi Tom,
On Wed, Jan 13, 2016 at 02:57:00PM -0500, Tom Rini wrote:
>On Tue, Jan 12, 2016 at 05:45:24PM +0800, Peng Fan wrote:
>
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Define CONFIG_SYS_VSNPRINTF to use snprintf. If not define
>> CONFIG_SYS_VSNPRINTF, snprintf is sprintf.
>>
>> Report by Coverity:
>> pass string init_val of unknown size to sprintf
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> Cc: Peter Robinson <pbrobinson@gmail.com>
>> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>> Cc: Adrian Alonso <aalonso@freescale.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>
>I'm not sure how I feel about fixing this range of issues only for
>certain targets. I need to do some global building here and see what
>happens.
With CONFIG_SYS_VSNPRINTF defined, image size may be bigger. So here,
I use #ifdef CONFIG_SPL_BUILD.
Ok, wait for your further comments on this.
Regards,
Peng.
>
>--
>Tom
next prev parent reply other threads:[~2016-01-14 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 9:45 [U-Boot] [PATCH] imx: mx6/7 define CONFIG_SYS_VSNPRINTF Peng Fan
2016-01-13 19:57 ` Tom Rini
2016-01-14 1:54 ` Peng Fan [this message]
2016-01-14 2:24 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114015407.GA2304@linux-7smt.suse \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox