From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Thu, 14 Jan 2016 09:54:09 +0800 Subject: [U-Boot] [PATCH] imx: mx6/7 define CONFIG_SYS_VSNPRINTF In-Reply-To: <20160113195700.GJ3359@bill-the-cat> References: <1452591924-24012-1-git-send-email-van.freenix@gmail.com> <20160113195700.GJ3359@bill-the-cat> Message-ID: <20160114015407.GA2304@linux-7smt.suse> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On Wed, Jan 13, 2016 at 02:57:00PM -0500, Tom Rini wrote: >On Tue, Jan 12, 2016 at 05:45:24PM +0800, Peng Fan wrote: > >> From: Peng Fan >> >> Define CONFIG_SYS_VSNPRINTF to use snprintf. If not define >> CONFIG_SYS_VSNPRINTF, snprintf is sprintf. >> >> Report by Coverity: >> pass string init_val of unknown size to sprintf >> >> Signed-off-by: Peng Fan >> Cc: Peter Robinson >> Cc: Fabio Estevam >> Cc: Adrian Alonso >> Cc: Stefano Babic > >I'm not sure how I feel about fixing this range of issues only for >certain targets. I need to do some global building here and see what >happens. With CONFIG_SYS_VSNPRINTF defined, image size may be bigger. So here, I use #ifdef CONFIG_SPL_BUILD. Ok, wait for your further comments on this. Regards, Peng. > >-- >Tom