public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL
Date: Thu, 14 Jan 2016 03:50:13 +0100	[thread overview]
Message-ID: <201601140350.13700.marex@denx.de> (raw)
In-Reply-To: <569709D5.40507@nelint.com>

On Thursday, January 14, 2016 at 03:37:09 AM, Eric Nelson wrote:
> Hi Marek,

Hi!

> On 01/13/2016 07:10 PM, Marek Vasut wrote:
> > On Tuesday, December 22, 2015 at 04:37:12 PM, Eric Nelson wrote:
> >> Hi Marek,
> > 
> > Hi Eric,
> > 
> > [..]
> > 
> >>>> This should also have parameters of mx6_ddr_sysinfo (input) and
> >>>> mx6_mmdc_calibration (output), at least for sysinfo->dsize
> >>> 
> >>> Would it be possible for you to send a subsequent patch(set)? I would
> >>> like to have this code as a working base , since I tested this
> >>> thoroughly. If I apply all of your changes, it would basically mean
> >>> almost complete rewrite of the code and that would disallow me bisect
> >>> possible bugs introduced by these changes.
> >> 
> >> I think that's a bit of overstatement, but I'm okay sending patches
> >> in principle.
> >> 
> >> I do think that at least the test for calibration failure should be
> >> fixed before your patch is applied.
> >> 
> >> This also has the benefit of allowing discussion about each of
> >> my points individually instead of in one e-mail thread.
> > 
> > I have to admit I'm a bit lost in this. What do you say we ask Stefano
> > to apply this so people can start fiddling with it. I'd also like to
> > see the patches for MX6SX and your fixes (if you feel like it).
> 
> I'm okay with that.
> 
> I was hoping to check out the error handling code but unfortunately,
> the boards I have that are supporting SPL are all either i.MX6DL,
> i.MX6S, or i.MX6SL.
> 
> You should be able to force a failure by setting WALAT and/or RALAT
> to extreme values and see how the DDR controller responds.

I only have Q ;-) The DDR calibration code _should_ work on DL though.

Best regards,
Marek Vasut

  reply	other threads:[~2016-01-14  2:50 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 14:40 [U-Boot] [PATCH 1/2] arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL Marek Vasut
2015-12-16 14:40 ` [U-Boot] [PATCH 2/2] arm: imx6: Enable DDR calibration on Novena Marek Vasut
2015-12-20 19:46   ` Eric Nelson
     [not found]   ` <567702A6.9070107@cox.net>
2015-12-22  1:26     ` Marek Vasut
2015-12-22  8:30       ` Nikolay Dimitrov
2015-12-22 14:56         ` Marek Vasut
2015-12-16 15:00 ` [U-Boot] [PATCH 1/2] arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL Eric Nelson
2015-12-16 15:33   ` Marek Vasut
2015-12-16 16:28     ` Eric Nelson
2015-12-16 16:50       ` Marek Vasut
2015-12-16 17:07         ` Eric Nelson
2015-12-16 17:11           ` Marek Vasut
2015-12-17 15:39   ` Tim Harvey
2015-12-17 15:48     ` Eric Nelson
2015-12-17 15:36 ` Tim Harvey
2015-12-17 15:40   ` Marek Vasut
2015-12-17 16:15     ` Tim Harvey
2015-12-17 16:17       ` Marek Vasut
2015-12-17 21:32 ` Nikolay Dimitrov
2015-12-17 22:11   ` Marek Vasut
2015-12-20 19:31 ` Eric Nelson
2015-12-22  1:52   ` Marek Vasut
2015-12-22 15:37     ` Eric Nelson
2016-01-14  2:10       ` Marek Vasut
2016-01-14  2:37         ` Eric Nelson
2016-01-14  2:50           ` Marek Vasut [this message]
2016-01-14  2:52             ` Eric Nelson
2016-01-14  3:06               ` Marek Vasut
2016-01-14 14:25                 ` Tim Harvey
2016-01-24 10:47                   ` Stefano Babic
2016-01-24 16:01                     ` Marek Vasut
2016-01-24 17:03                       ` Stefano Babic
2016-01-24 17:11                         ` Marek Vasut
2016-01-24 17:18                           ` Stefano Babic
2016-01-24 17:22                             ` Marek Vasut
2016-01-24 19:33                               ` Tom Rini
2016-01-24 22:07                                 ` Marek Vasut
2016-01-24 22:21                                   ` Tom Rini
2016-01-24 23:00                                     ` Marek Vasut
2016-01-24 23:30                                       ` Tom Rini
2016-01-24 23:55                                         ` Marek Vasut
2016-01-31 17:25                                         ` Marek Vasut
2016-06-02 13:20                                           ` Tim Harvey
2016-06-02 14:23                                             ` Stefano Babic
2016-06-02 15:25                                               ` Tim Harvey
2015-12-22  4:13   ` Tim Harvey
2015-12-22 14:47     ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201601140350.13700.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox