public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 00/10] add support for atheros ath79 based SOCs
Date: Sat, 16 Jan 2016 06:26:39 +0100	[thread overview]
Message-ID: <201601160626.39480.marex@denx.de> (raw)
In-Reply-To: <BLU436-SMTP1870A15D175818536B00DF6FFF20@phx.gbl>

On Monday, January 04, 2016 at 12:06:17 PM, Wills Wang wrote:
> These series of patch add support for atheros ath79 based SOCs in u-boot,
> at the present moment it's just available for ar933x and qca953x chip.
> 
> Changes in v6:
> - Remove useless "else"
> - Move ar933x as separate patch
> - Add get_bootstrap in reset.c
> - Use map_physmem instead of KSEG1ADDR
> - Add arch_cpu_init for detect SOC type for early
> - Define magic value in ddr.c
> - Remove wait loop in putc and getc
> - Use map_physmem instead of KSEG1ADDR
> - Add rrw_delay in ath79_spi_priv for more accurate timing
> - Remove ath79_spi_delay
> - Calculate delay in ath79_spi_set_speed
> - Convert SZ_XXX into hex in ap121.h
> - Remove useless CONFIG_SYS_INIT_SP_OFFSET in ap121.h
> - Add board_early_init_f for DDR and pin initialization
> - Select UART and SPI in ap121_defconfig
> - Add support for qca953x

I wanted to try this patchset, so I picked [1], since I didn't feel like fishing
out patches from the list. Especially since this wasn't sent as a series, but as
separate patches, which makes things annoying.

The [1] does not even compile, which is surprising. I would expect that if you 
submit patches, you would at least compile-test them. Sigh. I needed this patch:

---8<---
diff --git a/arch/mips/mach-ath79/cpu.c b/arch/mips/mach-ath79/cpu.c
index 2952679..140c65c 100644
--- a/arch/mips/mach-ath79/cpu.c
+++ b/arch/mips/mach-ath79/cpu.c
@@ -9,8 +9,8 @@
 #include <asm/io.h>
 #include <asm/addrspace.h>
 #include <asm/types.h>
-#include <asm/arch/ath79.h>
-#include <asm/arch/ar71xx_regs.h>
+#include <mach/ath79.h>
+#include <mach/ar71xx_regs.h>
 
 struct ath79_soc_desc {
        enum ath79_soc_type soc;
diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c
index 410b900..fe32d80 100644
--- a/arch/mips/mach-ath79/reset.c
+++ b/arch/mips/mach-ath79/reset.c
@@ -9,7 +9,7 @@
 #include <asm/io.h>
 #include <asm/addrspace.h>
 #include <asm/types.h>
-#include <asm/arch/ath79.h>
+#include <mach/ath79.h>
 #include <mach/ar71xx_regs.h>
                                                                                                                                                  
 void _machine_restart(void)
--->8---

Once I managed to fix things, I compiled ap121. I tried booting it on arduino
yun (ar9331), but it hung in start.S in setup_c0_status . If I comment this
out, it hangs in lowlevel_init, right at the beginning. That's where I gave up.

[1] http://git.denx.de/?p=u-boot/u-boot-
mips.git;a=shortlog;h=refs/heads/mips_ath79_v6

Best regards,
Marek Vasut

  reply	other threads:[~2016-01-16  5:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 11:06 [U-Boot] [PATCH v6 00/10] add support for atheros ath79 based SOCs Wills Wang
2016-01-16  5:26 ` Marek Vasut [this message]
2016-01-16 13:15   ` Wills Wang
2016-01-16 15:33     ` Marek Vasut
2016-01-16 16:08       ` Wills Wang
2016-01-16 19:04         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201601160626.39480.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox