From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl_qspi: fix address mask issue
Date: Wed, 20 Jan 2016 09:13:59 +0800 [thread overview]
Message-ID: <20160120011357.GA32712@linux-7smt.suse> (raw)
In-Reply-To: <1453208838-10306-1-git-send-email-ye.li@nxp.com>
On Tue, Jan 19, 2016 at 09:07:18PM +0800, Ye Li wrote:
>The OFFSET_BITS_MASK should mask bit from 0-23.
>By using GENMASK(24, 0), when using the fast read common (0xb), a
>invalid sf_addr 0x1000000 is produced by swab32(txbuf) & OFFSET_BITS_MASK.
>
>Signed-off-by: Ye Li <ye.li@nxp.com>
>---
> drivers/spi/fsl_qspi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c
>index feec3e8..542b6cf 100644
>--- a/drivers/spi/fsl_qspi.c
>+++ b/drivers/spi/fsl_qspi.c
>@@ -25,7 +25,7 @@ DECLARE_GLOBAL_DATA_PTR;
> #define TX_BUFFER_SIZE 0x40
> #endif
>
>-#define OFFSET_BITS_MASK GENMASK(24, 0)
>+#define OFFSET_BITS_MASK GENMASK(23, 0)
>
> #define FLASH_STATUS_WEL 0x02
Reviewed-by: Peng Fan <peng.fan@nxp.com>
>
>--
>1.7.4.1
>
>_______________________________________________
>U-Boot mailing list
>U-Boot at lists.denx.de
>http://lists.denx.de/mailman/listinfo/u-boot
next prev parent reply other threads:[~2016-01-20 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 13:07 [U-Boot] [PATCH] fsl_qspi: fix address mask issue Ye Li
2016-01-20 1:13 ` Peng Fan [this message]
2016-02-02 16:22 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120011357.GA32712@linux-7smt.suse \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox