From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Wed, 20 Jan 2016 09:13:59 +0800 Subject: [U-Boot] [PATCH] fsl_qspi: fix address mask issue In-Reply-To: <1453208838-10306-1-git-send-email-ye.li@nxp.com> References: <1453208838-10306-1-git-send-email-ye.li@nxp.com> Message-ID: <20160120011357.GA32712@linux-7smt.suse> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jan 19, 2016 at 09:07:18PM +0800, Ye Li wrote: >The OFFSET_BITS_MASK should mask bit from 0-23. >By using GENMASK(24, 0), when using the fast read common (0xb), a >invalid sf_addr 0x1000000 is produced by swab32(txbuf) & OFFSET_BITS_MASK. > >Signed-off-by: Ye Li >--- > drivers/spi/fsl_qspi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c >index feec3e8..542b6cf 100644 >--- a/drivers/spi/fsl_qspi.c >+++ b/drivers/spi/fsl_qspi.c >@@ -25,7 +25,7 @@ DECLARE_GLOBAL_DATA_PTR; > #define TX_BUFFER_SIZE 0x40 > #endif > >-#define OFFSET_BITS_MASK GENMASK(24, 0) >+#define OFFSET_BITS_MASK GENMASK(23, 0) > > #define FLASH_STATUS_WEL 0x02 Reviewed-by: Peng Fan > >-- >1.7.4.1 > >_______________________________________________ >U-Boot mailing list >U-Boot at lists.denx.de >http://lists.denx.de/mailman/listinfo/u-boot