From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] arm, ubifs: fix gcc5.x compiler warning
Date: Wed, 20 Jan 2016 16:00:27 -0500 [thread overview]
Message-ID: <20160120210027.GA3359@bill-the-cat> (raw)
In-Reply-To: <1448869662-23191-1-git-send-email-hs@denx.de>
On Mon, Nov 30, 2015 at 08:47:42AM +0100, Heiko Schocher wrote:
> compiling U-Boot for openrd_base_defconfig with
> gcc 5.x shows the following warning:
>
> CC fs/ubifs/super.o
> In file included from fs/ubifs/ubifs.h:35:0,
> from fs/ubifs/super.c:37:
> fs/ubifs/super.c: In function 'atomic_inc':
> ./arch/arm/include/asm/atomic.h:55:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
> local_irq_save(flags);
> ^
> fs/ubifs/super.c: In function 'atomic_dec':
> ./arch/arm/include/asm/atomic.h:64:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
> local_irq_save(flags);
> ^
> CC fs/ubifs/sb.o
> [...]
> CC fs/ubifs/lpt.o
> In file included from include/linux/bitops.h:123:0,
> from include/common.h:20,
> from include/ubi_uboot.h:17,
> from fs/ubifs/ubifs.h:37,
> from fs/ubifs/lpt.c:35:
> fs/ubifs/lpt.c: In function 'test_and_set_bit':
> ./arch/arm/include/asm/bitops.h:57:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
> local_irq_save(flags);
> ^
> CC fs/ubifs/lpt_commit.o
> In file included from include/linux/bitops.h:123:0,
> from include/common.h:20,
> from include/ubi_uboot.h:17,
> from fs/ubifs/ubifs.h:37,
> from fs/ubifs/lpt_commit.c:26:
> fs/ubifs/lpt_commit.c: In function 'test_and_set_bit':
> ./arch/arm/include/asm/bitops.h:57:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
> local_irq_save(flags);
> ^
> CC fs/ubifs/scan.o
> CC fs/ubifs/lprops.o
> CC fs/ubifs/tnc.o
> In file included from include/linux/bitops.h:123:0,
> from include/common.h:20,
> from include/ubi_uboot.h:17,
> from fs/ubifs/ubifs.h:37,
> from fs/ubifs/tnc.c:30:
> fs/ubifs/tnc.c: In function 'test_and_set_bit':
> ./arch/arm/include/asm/bitops.h:57:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
> local_irq_save(flags);
> ^
> CC fs/ubifs/tnc_misc.o
>
> Fix it.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
I've re-thought this problem. I'm not seeing a better way to work
around this problem without further divergence from upstream on these
functions, so thanks for doing this!
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160120/77eabc7d/attachment.sig>
prev parent reply other threads:[~2016-01-20 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 7:47 [U-Boot] [PATCH] arm, ubifs: fix gcc5.x compiler warning Heiko Schocher
2015-11-30 9:20 ` Jeroen Hofstee
2015-11-30 10:03 ` Heiko Schocher
2015-11-30 16:28 ` Tom Rini
2015-12-01 7:56 ` Albert ARIBAUD
2015-12-02 14:39 ` Tom Rini
2015-11-30 23:48 ` Jeroen Hofstee
2016-01-20 21:00 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120210027.GA3359@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox