From: Thierry Reding <thierry.reding@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: tegra: rm Jetson TK1 PMIC GPIO programming
Date: Fri, 22 Jan 2016 16:52:44 +0100 [thread overview]
Message-ID: <20160122155244.GB19357@ulmo.nvidia.com> (raw)
In-Reply-To: <1453141396-18350-1-git-send-email-swarren@wwwdotorg.org>
On Mon, Jan 18, 2016 at 11:23:16AM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The PMIC is configured such that its GPIOs have the correct configuration
> at power-up, so no programming is required.
>
> In fact, the current programming is actively wrong, since:
>
> (a) the AS3722 driver configures the GPIO to be an output before setting
> its output value, which causes a 0v glitch on the output.
>
> (b) the AS3722 driver configures the GPIO to drive a high voltage from its
> VSUP_GPIO power source rather than its VDD_GPIO_LV power source, so the pin
> drives 5V not 1.8V as desired.
>
> Solve these problems by removing the code which configures the PMIC GPIOs.
>
> Note that this patch was tested directly on top of v2016.01; since then,
> commit 96350f729c42 "dm: tegra: net: Convert tegra boards to driver model
> for Ethernet" prevents PCIe from being initialized. Alternatively, simply
> revert that commit to get PCIe Ethernet working again, then apply this
> patch to test.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> board/nvidia/jetson-tk1/jetson-tk1.c | 13 -------------
> 1 file changed, 13 deletions(-)
After applying your other patch:
pci: restore initialization for DM_PCI
to restore PCI networking on Jetson TK1 I was able to verify that this
still works for me. Interestingly the code before seems to trigger a
visual glitch in the serial output, though I'm not sure I had seen one
like that back when I initially added this support.
Either way, this patch:
Tested-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160122/e3fdbde9/attachment.sig>
prev parent reply other threads:[~2016-01-22 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 18:23 [U-Boot] [PATCH] ARM: tegra: rm Jetson TK1 PMIC GPIO programming Stephen Warren
2016-01-18 19:16 ` Tom Warren
2016-01-28 17:11 ` Stephen Warren
2016-01-28 17:30 ` Tom Warren
2016-01-19 13:10 ` Thierry Reding
2016-01-22 15:52 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160122155244.GB19357@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox