public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] test/py: move find_ram_base() into u_boot_utils
Date: Fri, 22 Jan 2016 23:30:11 +0100	[thread overview]
Message-ID: <20160122223011.E743A3811CD@gemini.denx.de> (raw)
In-Reply-To: <1453417531-23669-1-git-send-email-swarren@wwwdotorg.org>

Dear Stephen,

In message <1453417531-23669-1-git-send-email-swarren@wwwdotorg.org> you wrote:
> 
> find_ram_base() is a shared utility function, not a core part of the
> U-Boot console interaction.

On which boards did you test this feature?  Eventually ARM only?

> +    with u_boot_console.log.section('find_ram_base'):
> +        response = u_boot_console.run_command('bdinfo')
> +        for l in response.split('\n'):
> +            if '-> start' in l:
> +                ram_base = int(l.split('=')[1].strip(), 16)
> +                break

Searching for "-> start" is probably not exactly portable.  For
example, on a PowerPC system the output of "bdi" might look like this:

=> bdi
memstart    = 0x00000000
memsize     = 0x04000000
flashstart  = 0xFC000000
flashsize   = 0x02000000
flashoffset = 0x0005D000
sramstart   = 0x00000000
sramsize    = 0x00000000
bootflags   = 0x00000000
intfreq     =    396 MHz
busfreq     =    132 MHz
ethaddr     = 00:D0:93:2A:C2:1A
IP addr     = 192.168.240.240
baudrate    = 115200 bps
relocaddr   = 0x03F47000
=> 

[example is from a TQM5200S, U-Boot 2016.01-00223-gb57843e]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When choosing between two evils, I always like to take the  one  I've
never tried before.                     -- Mae West, "Klondike Annie"

  parent reply	other threads:[~2016-01-22 22:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-21 23:05 [U-Boot] [PATCH 1/2] test/py: move find_ram_base() into u_boot_utils Stephen Warren
2016-01-21 23:05 ` [U-Boot] [PATCH 2/2] test/py: add a networking test Stephen Warren
2016-01-22  3:36   ` Simon Glass
2016-01-26  1:15     ` Simon Glass
2016-01-22  3:36 ` [U-Boot] [PATCH 1/2] test/py: move find_ram_base() into u_boot_utils Simon Glass
2016-01-22 22:30 ` Wolfgang Denk [this message]
2016-01-25 16:50   ` Stephen Warren
2016-01-26  1:03     ` Simon Glass
2016-01-26  1:09       ` Stephen Warren
2016-01-26  1:15         ` Simon Glass
2016-01-26 18:13           ` Stephen Warren
2016-01-26 19:59             ` Simon Glass
2016-01-26 20:08               ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160122223011.E743A3811CD@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox