From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] net: bootp: Ignore packets whose yiaddr is 0
Date: Mon, 25 Jan 2016 09:50:31 +0800 [thread overview]
Message-ID: <20160125015030.GA22283@linux-7smt.suse> (raw)
In-Reply-To: <20160107160904.24DA4380311@gemini.denx.de>
Gentle ping..
Regards,
Peng.
On Thu, Jan 07, 2016 at 05:09:04PM +0100, Wolfgang Denk wrote:
>Dear Peng Fan,
>
>In message <1452151703-30647-1-git-send-email-van.freenix@gmail.com> you wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> When doing `dhcp`, there is a bad dhcp server in my network
>> which always reply dhcp request with yiaddr 0, which cause
>> uboot can not successfully get ipaddr from the good dhcp server.
>> But the Linux PC can get the ip address even if there is a bad
>> dhcp server. This patch is to fix that even if there is a bad
>> dhcp server, uboot can still get ipaddr and tftp work ok.
>>
>> The way is to ignore the packets from the bad dhcp server by filtering
>> out the yiaddr whose value is 0.
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> Cc: Joe Hershberger <joe.hershberger@ni.com>
>> ---
>>
>> Changes V2:
>> Take Wolfgang's suggestion, move the code after debug message.
>
>THanks.
>
>Reviewed-by: Wolfgang Denk <wd@denx.de>
>
>Best regards,
>
>Wolfgang Denk
>
>--
>DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
>HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
>About the use of language: it is impossible to sharpen a pencil with
>a blunt ax. It is equally vain to try to do it with ten blunt axes
>instead. -- Edsger Dijkstra
next prev parent reply other threads:[~2016-01-25 1:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 7:28 [U-Boot] [PATCH V2] net: bootp: Ignore packets whose yiaddr is 0 Peng Fan
2016-01-07 16:09 ` Wolfgang Denk
2016-01-25 1:50 ` Peng Fan [this message]
2016-01-25 14:59 ` Joe Hershberger
2016-01-29 21:26 ` [U-Boot] " Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125015030.GA22283@linux-7smt.suse \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox